Skip to content

fix: i18n issues reported by crowdin#11160

Merged
leog merged 1 commit intomainfrom
fix/i18n-issues
Sep 5, 2023
Merged

fix: i18n issues reported by crowdin#11160
leog merged 1 commit intomainfrom
fix/i18n-issues

Conversation

@leog
Copy link
Copy Markdown
Contributor

@leog leog commented Sep 5, 2023

What does this PR do?

Crowdin team reported that some multi-use strings were giving problems to translate to certain languages, so a couple of strings were splitted and one removed as it was not longer being used.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

Emails regarding invitation to a team or org should continue to display the right copy.

@leog leog requested a review from a team September 5, 2023 21:15
@leog leog self-assigned this Sep 5, 2023
@vercel
Copy link
Copy Markdown

vercel Bot commented Sep 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ❌ Failed (Inspect) Sep 5, 2023 9:22pm
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2023 9:22pm
cal-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2023 9:22pm
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2023 9:22pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2023 9:22pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Sep 5, 2023 9:22pm

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 5, 2023

Thank you for following the naming conventions! 🙏

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 5, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link
Copy Markdown

deploysentinel Bot commented Sep 5, 2023

Current Playwright Test Results Summary

✅ 117 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 09/05/2023 09:22:57pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: c7aa24e

Started: 09/05/2023 09:21:12pm UTC

⚠️ Flakes

📄   apps/web/playwright/onboarding.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Onboarding Onboarding v2 Onboarding Flow
Retry 1Initial Attempt
0% (0) 0 / 320 runs
failed over last 7 days
2.50% (8) 8 / 320 runs
flaked over last 7 days

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests user can duplicate an existing event type
Retry 1Initial Attempt
0.31% (1) 1 / 322 run
failed over last 7 days
5.90% (19) 19 / 322 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 1Initial Attempt
5.61% (18) 18 / 321 runs
failed over last 7 days
93.15% (299) 299 / 321 runs
flaked over last 7 days

View Detailed Build Results


@leog leog merged commit a2d521e into main Sep 5, 2023
@leog leog deleted the fix/i18n-issues branch September 5, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants