fix: Installing Zoho CRM#11161
Merged
kodiakhq[bot] merged 3 commits intomainfrom Sep 6, 2023
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
Contributor
|
Thank you for following the naming conventions! 🙏 |
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
|
No failed tests 🎉 |
joeauyeung
commented
Sep 5, 2023
Comment on lines
-16
to
+25
| const redirectUri = WEBAPP_URL + "/api/integrations/zohocrm/callback"; | ||
| const url = `https://accounts.zoho.com/oauth/v2/auth?scope=ZohoCRM.modules.ALL,ZohoCRM.users.READ,AaaServer.profile.READ&client_id=${client_id}&response_type=code&access_type=offline&redirect_uri=${redirectUri}&state=${state}`; | ||
| const params = { | ||
| client_id, | ||
| response_type: "code", | ||
| redirect_uri: WEBAPP_URL + "/api/integrations/zohocrm/callback", | ||
| scope: ["ZohoCRM.modules.ALL", "ZohoCRM.users.READ", "AaaServer.profile.READ"], | ||
| access_type: "offline", | ||
| state, | ||
| prompt: "consent", | ||
| }; |
Contributor
Author
There was a problem hiding this comment.
It was hard to debug what was wrong, so let's separate the URL params. Credit to @murtajaziad in #10429
Member
There was a problem hiding this comment.
I think just prompt was missing. Earlier it was working fine, maybe Zoho changed something?
3 tasks
hariombalhara
approved these changes
Sep 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a 400 error when installing Zoho CRM
Fixes # (issue)
Requirement/Documentation
Type of change
How should this be tested?
Mandatory Tasks
Checklist