fix: Messaging apps listed under conferencing tab in Installed Apps section#11167
Merged
hariombalhara merged 3 commits intomainfrom Sep 18, 2023
Merged
fix: Messaging apps listed under conferencing tab in Installed Apps section#11167hariombalhara merged 3 commits intomainfrom
hariombalhara merged 3 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
Contributor
|
Thank you for following the naming conventions! 🙏 |
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 121 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 09/18/2023 02:51:29pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 9970d7d Started: 09/18/2023 02:49:47pm UTC
|
|
|
4 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
2.16% (6)6 / 278 runsfailed over last 7 days |
14.75% (41)41 / 278 runsflaked over last 7 days |
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
1.80% (5)5 / 278 runsfailed over last 7 days |
96.76% (269)269 / 278 runsflaked over last 7 days |
|
Popup Tests should open Routing Forms embed on click
Retry 1 • Initial Attempt |
0.36% (1)1 / 278 runfailed over last 7 days |
10.43% (29)29 / 278 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
1.80% (5)5 / 278 runsfailed over last 7 days |
11.15% (31)31 / 278 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 1 • Initial Attempt |
1.78% (5)5 / 281 runsfailed over last 7 days |
10.32% (29)29 / 281 runsflaked over last 7 days |
2 tasks
hariombalhara
changed the title
hariombalhara
changed the title
ashwintelmore
pushed a commit
to ashwintelmore/cal.com
that referenced
this pull request
Sep 24, 2023
Co-authored-by: Joe Au-Yeung <65426560+joeauyeung@users.noreply.github.com>
aar2dee2
pushed a commit
to rkreddy99/cal.com
that referenced
this pull request
Sep 27, 2023
Co-authored-by: Joe Au-Yeung <65426560+joeauyeung@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
On the installed apps page, messaging apps were not being properly rendered in the right category
Notice that Telegram appears under Conferencing after installation instead of Messaging.
Screenshots taken from #10653
Type of change
Mandatory Tasks
Checklist