Skip to content

fix: Fixed SVG icons on light and dark mode#11173

Merged
PeerRich merged 2 commits intocalcom:mainfrom
pateldivyesh1323:11170
Sep 7, 2023
Merged

fix: Fixed SVG icons on light and dark mode#11173
PeerRich merged 2 commits intocalcom:mainfrom
pateldivyesh1323:11170

Conversation

@pateldivyesh1323
Copy link
Copy Markdown
Contributor

@pateldivyesh1323 pateldivyesh1323 commented Sep 6, 2023

What does this PR do?

Fixed SVG icons behaviour on light and dark modes

Fixes #11170

Before:
Capture
Screenshot (62)
Screenshot (63)

After:
Capture1
Capture2
Screenshot (64)
Screenshot (65)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I haven't checked if my changes generate no new warnings

@vercel
Copy link
Copy Markdown

vercel Bot commented Sep 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2023 0:23am

@vercel
Copy link
Copy Markdown

vercel Bot commented Sep 6, 2023

@pateldivyesh1323 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 6, 2023

Thank you for following the naming conventions! 🙏

@github-actions github-actions Bot added ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work 🐛 bug Something isn't working labels Sep 6, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 6, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@pateldivyesh1323 pateldivyesh1323 changed the title fix: Fixed-SVG-icons-on-light-and-dark-mode fix: Fixed SVG icons on light and dark mode Sep 6, 2023
@pateldivyesh1323
Copy link
Copy Markdown
Contributor Author

@PeerRich please review this PR

@PeerRich PeerRich merged commit 69888c5 into calcom:main Sep 7, 2023
@pateldivyesh1323 pateldivyesh1323 deleted the 11170 branch September 8, 2023 10:29
ashwintelmore pushed a commit to ashwintelmore/cal.com that referenced this pull request Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

defaultEventLocation icon color in dark mode

2 participants