Conversation
# Conflicts: # packages/prisma/package.json # packages/prisma/schema.prisma # packages/trpc/server/createContext.ts # yarn.lock
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
|
Thank you for following the naming conventions! 🙏 |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Three Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
|
No failed tests 🎉 |
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: @prisma/client@5.0.0, prisma@5.0.0 |
keithwillcode
added
High priority
|
|
||
| describe("Check Booking Limits Tests", () => { | ||
| it("Should return no errors", async () => { | ||
| // @ts-expect-error Prisma v5 typings are not yet available |
There was a problem hiding this comment.
Prisma client with extensions break Vitest deep Mocking
There was a problem hiding this comment.
Is there any estimate on when this is coming? Maybe it is worth creating a follow-up issue to tackle this when the time comes
| // TODO: Re-enable once we get confirmation from compliance that this is okay. | ||
| // cacheStrategy: { ttl: 60, swr: 1 }, |
There was a problem hiding this comment.
Until we get confirmation from compliance @keithwillcode @ConnorGargano
|
|
||
| describe("Check Booking Limits Tests", () => { | ||
| it("Should return no errors", async () => { | ||
| // @ts-expect-error Prisma v5 typings are not yet available |
There was a problem hiding this comment.
Is there any estimate on when this is coming? Maybe it is worth creating a follow-up issue to tackle this when the time comes
| isUser: true, | ||
| ...(includeCredentials && { credentials: user.credentials }), | ||
| credentials: includeCredentials ? [] : user.credentials, | ||
| parent: null, |
There was a problem hiding this comment.
It was messing with the type signature. This makes it more consistent
|
Pushed public API build fixes. Should be good to go. |
5 participants
What does this PR do?
Requirement/Documentation
Type of change
How should this be tested?
Mandatory Tasks
Checklist