Skip to content

fix: org invite#11356

Merged
hariombalhara merged 22 commits intomainfrom
fix/org-invite
Sep 19, 2023
Merged

fix: org invite#11356
hariombalhara merged 22 commits intomainfrom
fix/org-invite

Conversation

@Udit-takkar
Copy link
Copy Markdown
Contributor

@Udit-takkar Udit-takkar commented Sep 14, 2023

What does this PR do?

Fixes #11311

Screen.Recording.2023-09-14.at.11.23.31.PM.mov

How to test this ?

  1. Create an organization
  2. Go to http://app.cal.local:3000/settings/organizations/members and click on +Add
  3. Click on "Copy Invite Link" and open the link in incognito mode or another browser
  4. Sign up

NOTE: While testing locally you might have to comment the line await navigator.clipboard.writeText(inviteLink) and get the invite link by logging in on console.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
@vercel
Copy link
Copy Markdown

vercel Bot commented Sep 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2023 11:15pm
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2023 11:15pm
cal-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2023 11:15pm
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2023 11:15pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2023 11:15pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2023 11:15pm
qa ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2023 11:15pm

@github-actions github-actions Bot added High priority Created by Linear-GitHub Sync organizations area: organizations, orgs teams area: teams, round robin, collective, managed event-types 🐛 bug Something isn't working labels Sep 14, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 14, 2023

Thank you for following the naming conventions! 🙏

@deploysentinel
Copy link
Copy Markdown

deploysentinel Bot commented Sep 14, 2023

Current Playwright Test Results Summary

✅ 121 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 09/18/2023 11:17:38pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: f65d0bb

Started: 09/18/2023 11:15:24pm UTC

⚠️ Flakes

📄   apps/web/playwright/login.2fa.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 1Initial Attempt
4.98% (14) 14 / 281 runs
failed over last 7 days
26.69% (75) 75 / 281 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 1Initial Attempt
2.02% (6) 6 / 297 runs
failed over last 7 days
96.63% (287) 287 / 297 runs
flaked over last 7 days

📄   apps/web/playwright/webhook.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
FORM_SUBMITTED on submitting team form, triggers team webhook
Retry 1Initial Attempt
0.36% (1) 1 / 278 run
failed over last 7 days
6.47% (18) 18 / 278 runs
flaked over last 7 days

View Detailed Build Results


@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 14, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
Udit Takkar added 5 commits September 14, 2023 22:56
Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
@hariombalhara
Copy link
Copy Markdown
Member

Not a blocker for this PR but I see an option to add existing team members to a team. Adding those who have accepted the request, throws error but adding those who are in Pending state silently ignores that it's already added.
https://www.loom.com/share/48bd8659a4424185b7e42ff3eff98af3

@hariombalhara
Copy link
Copy Markdown
Member

Not sure, if related to the changes in here but I see that members get duplicated in the list when inviting a new team member.
https://www.loom.com/share/f4d4b8d821db4cd1bc77ab46fa08f5d0

Copy link
Copy Markdown
Member

@hariombalhara hariombalhara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mergeable now !!

@Udit-takkar
Copy link
Copy Markdown
Contributor Author

Not a blocker for this PR but I see an option to add existing team members to a team. Adding those who have accepted the request, throws error but adding those who are in Pending state silently ignores that it's already added. https://www.loom.com/share/48bd8659a4424185b7e42ff3eff98af3

OK i'll open up issue for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working core area: core, team members only High priority Created by Linear-GitHub Sync organizations area: organizations, orgs teams area: teams, round robin, collective, managed event-types

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-2457] copying an invite link doesn't account for orgs + regular team expiration issue

4 participants