fix: 2FA password visibility toggle show/hide state#11361
Conversation
|
@Chiranjeev-droid is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thank you for following the naming conventions! 🙏 |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Five Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
hariombalhara
left a comment
There was a problem hiding this comment.
Thanks @Chiranjeev-droid 🙏 Nice fix!!
What does this PR do?
Previously, when users attempted to enable two-factor authentication (2FA) on our platform, they encountered an issue with the password visibility toggle. Specifically, when they entered their current password for confirmation, it remained hidden, making it difficult to verify the input. However, with the recent code update, I have addressed this usability concern. Users can now see and toggle the visibility of their current password when confirming their choice to enable 2FA. This improvement enhances the overall user experience, making the process smoother and more intuitive.
Loom Video:
Before change :- https://www.loom.com/share/Profile-or-Calcom-14-September-2023-bb68faf8d15449f796f2ff3782a7825e?sid=ad9c41e0-0f20-4985-9a7f-217f6472775d
After Making change
https://www.loom.com/share/Two-Factor-Authentication-or-Calcom-14-September-2023-1ac49793c94f4ed9a8e19489d0b95458?sid=afe90a92-892a-4061-b007-64be4b4a2454
Type of change
How should this be tested?
3.For enabling 2 factor auth, enter your password and click on eye icon to view your password and you wont be able to see.
Mandatory Tasks