Skip to content

fix: Email Embed slots not showing up#11379

Merged
zomars merged 3 commits intomainfrom
fix/email-embed-slots-selection
Sep 15, 2023
Merged

fix: Email Embed slots not showing up#11379
zomars merged 3 commits intomainfrom
fix/email-embed-slots-selection

Conversation

@hariombalhara
Copy link
Copy Markdown
Member

@hariombalhara hariombalhara commented Sep 15, 2023

What does this PR do?

Fix slots not showing up for email embed
Fixes #11377
Regression from #10996
After Fix loom

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

See the loom above

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works

@hariombalhara hariombalhara added the 📉 regressing This used to work. Now it doesn't anymore. label Sep 15, 2023
@vercel
Copy link
Copy Markdown

vercel Bot commented Sep 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview Sep 15, 2023 9:03am
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 15, 2023 9:03am
cal-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 15, 2023 9:03am
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 15, 2023 9:03am
ui ✅ Ready (Inspect) Visit Preview Sep 15, 2023 9:03am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Sep 15, 2023 9:03am

@hariombalhara hariombalhara changed the title Fix yarn.lock fix: Email Embed slots not showing up Sep 15, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 15, 2023

Thank you for following the naming conventions! 🙏

@github-actions
Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link
Copy Markdown

deploysentinel Bot commented Sep 15, 2023

Current Playwright Test Results Summary

✅ 121 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 09/15/2023 09:09:04am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 25d0c29

Started: 09/15/2023 09:07:41am UTC

⚠️ Flakes

📄   apps/web/playwright/webhook.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
FORM_SUBMITTED on submitting team form, triggers team webhook
Retry 1Initial Attempt
0.39% (1) 1 / 256 run
failed over last 7 days
6.64% (17) 17 / 256 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 1Initial Attempt
1.87% (5) 5 / 267 runs
failed over last 7 days
96.63% (258) 258 / 267 runs
flaked over last 7 days

View Detailed Build Results


@hariombalhara hariombalhara added the High priority Created by Linear-GitHub Sync label Sep 15, 2023
@hariombalhara
Copy link
Copy Markdown
Member Author

Marked urgent for it is completely breaking a functionality.

Copy link
Copy Markdown
Contributor

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zomars zomars merged commit ab77531 into main Sep 15, 2023
@zomars zomars deleted the fix/email-embed-slots-selection branch September 15, 2023 19:24
ashwintelmore pushed a commit to ashwintelmore/cal.com that referenced this pull request Sep 19, 2023
aar2dee2 pushed a commit to rkreddy99/cal.com that referenced this pull request Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working core area: core, team members only embed area: embed, widget, react embed High priority Created by Linear-GitHub Sync 📉 regressing This used to work. Now it doesn't anymore.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-2473] Email Embed slot selection not working

2 participants