fix: Safari overflowing issues#11385
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
Thank you for following the naming conventions! 🙏 |
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 121 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 09/15/2023 01:53:44pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 37ae1c9 Started: 09/15/2023 01:51:42pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Stripe integration When event is paid and confirmed Payment should confirm pending payment booking
Retry 1 • Initial Attempt |
0% (0)0 / 271 runsfailed over last 7 days |
7.38% (20)20 / 271 runsflaked over last 7 days |
📄 apps/web/playwright/availability.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Availablity tests Date Overrides
Retry 1 • Initial Attempt |
1.75% (5)5 / 286 runsfailed over last 7 days |
1.40% (4)4 / 286 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
1.77% (5)5 / 282 runsfailed over last 7 days |
96.81% (273)273 / 282 runsflaked over last 7 days |
PeerRich
approved these changes
Sep 15, 2023
ashwintelmore
pushed a commit
to ashwintelmore/cal.com
that referenced
this pull request
Sep 19, 2023
aar2dee2
pushed a commit
to rkreddy99/cal.com
that referenced
this pull request
Sep 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #11343
Reason for breaking - safari tried to display all child elements and since there was no space they all clipped (Drawback to using
dangerouslySetInnerHTMLthey all just get placed thereAdd hidden class to all children apart form the first child
Before:
After:
