Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
github-actions
Bot
added
High priority
Contributor
|
Thank you for following the naming conventions! 🙏 |
…oint-again-possible-bug-with-state-changing-when-it-shouldnt-11352-cal-2466
alannnc
commented
Sep 16, 2023
| </h3> | ||
| <p className="text-default mt-2 hidden text-sm md:block">{t("insights_subtitle")}</p> | ||
| </div> | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
Removed since a change in shell that has the same was introduced recently by a contributor.
alannnc
commented
Sep 16, 2023
| const [startDate, endDate] = dateRange; | ||
| const { selectedTeamId: teamId, selectedUserId } = filter; | ||
|
|
||
| const initialConfigIsReady = !!(initialConfig?.teamId || initialConfig?.userId || initialConfig?.isAll); |
Contributor
Author
There was a problem hiding this comment.
Don't load any trpc till we know if user belongs to an org/team
alannnc
commented
Sep 16, 2023
| filter.initialConfig?.userId || | ||
| filter.initialConfig?.isAll | ||
| ); | ||
| if (isInitialSetupAlready) return; |
Contributor
Author
There was a problem hiding this comment.
Only setup initialConfig once.
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 121 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 09/18/2023 07:23:34pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: b5e0325 Started: 09/18/2023 07:21:06pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Test preview should return correct route
Retry 1 • Initial Attempt |
0% (0)0 / 295 runsfailed over last 7 days |
1.69% (5)5 / 295 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
2.05% (6)6 / 292 runsfailed over last 7 days |
96.58% (282)282 / 292 runsflaked over last 7 days |
…oint-again-possible-bug-with-state-changing-when-it-shouldnt-11352-cal-2466
zomars
deleted the
fix-insights-re-renders-and-loads-every-endpoint-again-possible-bug-with-state-changing-when-it-shouldnt-11352-cal-2466
branch
ashwintelmore
pushed a commit
to ashwintelmore/cal.com
that referenced
this pull request
Sep 24, 2023
aar2dee2
pushed a commit
to rkreddy99/cal.com
that referenced
this pull request
Sep 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #11352
Requirement/Documentation
Type of change