feat: `Connect` component for Cal Atoms by Ryukemeister · Pull Request #11605 · calcom/cal.diy

Ryukemeister · 2023-09-29T06:41:48Z

What does this PR do?

Adds a Connect button component for Cal Atoms

vercel · 2023-09-29T06:41:58Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
ai	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 23, 2023 7:26am
api	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 23, 2023 7:26am
dev	❌ Failed (Inspect)			Nov 23, 2023 7:26am

4 Ignored Deployments

Name	Status	Preview	Updated (UTC)
cal	⬜️ Ignored (Inspect)	Visit Preview	Nov 23, 2023 7:26am
cal-demo	⬜️ Ignored (Inspect)	Visit Preview	Nov 23, 2023 7:26am
qa	⬜️ Ignored (Inspect)	Visit Preview	Nov 23, 2023 7:26am
ui	⬜️ Ignored (Inspect)	Visit Preview	Nov 23, 2023 7:26am

github-actions · 2023-09-29T06:42:02Z

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

github-actions · 2023-09-29T06:56:14Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

deploysentinel · 2023-09-29T06:57:54Z

Current Playwright Test Results Summary

✅ 136 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 10/06/2023 07:45:36am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: f0febb0

Started: 10/06/2023 07:43:23am UTC

⚠️ Flakes

📄 apps/web/playwright/profile.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Teams Profile page is loaded for users in Organization Retry 2 • Retry 1 • Initial Attempt	3.24% (6) 6 / 185 runs failed over last 7 days	28.65% (53) 53 / 185 runs flaked over last 7 days

📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Popup Tests should be able to reschedule Retry 1 • Initial Attempt	4.12% (10) 10 / 243 runs failed over last 7 days	93% (226) 226 / 243 runs flaked over last 7 days

View Detailed Build Results

supalarry

Well done Rajiv! Left some refactor comments.

Ryukemeister · 2023-10-27T12:54:45Z

 export function ConnectButton({
  buttonText,
-  handleClick,
+  onClick,


@supalarry this is the correct way to do it right?

Yeah i think this makes sense. Can you manually test it by using the component, passing onClick to it and seeing if it is fired when the button is clicked?

Should work IMHO but will test and let you know, great review btw!

@supalarry I added a loader for the button can you review it again and make sure it's alright?

Looks good!

PeerRich · 2023-11-02T11:27:21Z

just to confirm, this has no functionality yet right? Its supposed to connect to Google Calendar, zoom, etc.

Ryukemeister · 2023-11-02T12:23:00Z

just to confirm, this has no functionality yet right? Its supposed to connect to Google Calendar, zoom, etc.

Correct, it doesn't handle any functionality. The functionality can be passed in through the onClick handler and all button does is execute the method (connect to Google Calendar, zoom, etc) that will be passed onto it in the form of props.

PeerRich · 2023-11-09T10:37:45Z

Correct, it doesn't handle any functionality. The functionality can be passed in through the onClick handler and all button does is execute the method (connect to Google Calendar, zoom, etc) that will be passed onto it in the form of props.

ideally the Connect button has logic, especially the logic to connect to something. that's the whole point of this component.

<Connect to="Google Calendar"/>

(not final props API) but somewhat like this

Ryukemeister · 2023-11-09T11:11:49Z

Correct, it doesn't handle any functionality. The functionality can be passed in through the onClick handler and all button does is execute the method (connect to Google Calendar, zoom, etc) that will be passed onto it in the form of props.

ideally the Connect button has logic, especially the logic to connect to something. that's the whole point of this component.

<Connect to="Google Calendar"/>

(not final props API) but somewhat like this

Will keep this in mind

github-actions · 2023-12-08T00:17:38Z

This PR is being marked as stale due to inactivity.

github-actions · 2023-12-16T00:16:56Z

This PR is being closed due to inactivity. Please reopen if work is intended to be continued.

Init connect button component

1754b0a

Ryukemeister marked this pull request as draft September 29, 2023 06:42

zomars added the core area: core, team members only label Sep 29, 2023

vercel Bot deployed to Preview – ai September 29, 2023 06:42 View deployment

vercel Bot deployed to Preview – ui September 29, 2023 06:42 View deployment

Add types for connect button

c492c38

vercel Bot deployed to Preview – ai September 29, 2023 06:46 View deployment

update connect btn view

3f793ac

vercel Bot deployed to Preview – ai September 29, 2023 06:51 View deployment

rename button file

2ead68f

vercel Bot deployed to Preview – api September 29, 2023 06:56 View deployment

export connect button component

5e72a12

add connect button to atoms export

c928ea4

vercel Bot deployed to Preview – ai September 29, 2023 07:01 View deployment

vercel Bot deployed to Preview – api September 29, 2023 07:04 View deployment

fix imports

130d30c

vercel Bot deployed to Preview – ai September 29, 2023 07:10 View deployment

vercel Bot deployed to Preview – api September 29, 2023 07:12 View deployment

vercel Bot deployed to Preview – dev September 29, 2023 07:16 View deployment

vercel Bot deployed to Preview – cal-demo September 29, 2023 07:17 View deployment

Ryukemeister added 2 commits September 29, 2023 13:39

update typings

89fb9d2

add callback for error

af741a1

vercel Bot deployed to Preview – ai September 29, 2023 08:13 View deployment

vercel Bot deployed to Preview – api September 29, 2023 08:15 View deployment

vercel Bot deployed to Preview – dev September 29, 2023 08:16 View deployment

vercel Bot deployed to Preview – cal-demo September 29, 2023 08:17 View deployment

Ryukemeister commented Oct 13, 2023

View reviewed changes

Comment thread packages/atoms/connect/ConnectButton.tsx Outdated

supalarry reviewed Oct 27, 2023

View reviewed changes

Comment thread packages/atoms/connect/ConnectButton.tsx Outdated

Comment thread packages/atoms/connect/ConnectButton.tsx

Comment thread packages/atoms/src/lib/utils.ts

cleanup comments, replace && and rename function handler

7c2c94b

supalarry reviewed Oct 27, 2023

View reviewed changes

Comment thread packages/atoms/connect/ConnectButton.tsx Outdated

replace handleClick with generic onClick for button component

36f9e66

Ryukemeister commented Oct 27, 2023

View reviewed changes

Ryukemeister added 3 commits October 30, 2023 12:27

Merge branch 'main' into connect-component

7e452a2

add loading spinner

210173d

Merge branch 'main' into connect-component

580e6aa

supalarry requested changes Nov 2, 2023

View reviewed changes

Comment thread packages/atoms/connect/ConnectButton.tsx Outdated

Ryukemeister mentioned this pull request Nov 2, 2023

feat: AvailabilityList component #11772

Closed

5 tasks

Ryukemeister added 6 commits November 5, 2023 16:54

minor fixes

0992c6d

add useCallback for event handler

983d614

refactor

57b9c40

update comments

f14ab96

add async await to event handlers

102e413

Merge branch 'main' into connect-component

ce96479

Ryukemeister added 7 commits November 21, 2023 02:31

resolve conflicts

5739af3

split connect btn into video and calendars

c3583a5

update exports for connect component

a41e150

minor tweaks

9bead8a

update comments for flow of connect calendar atom

e6a39eb

add component that connects to cal.com

c510136

Merge branch 'main' into connect-component

bd5256b

Conversation

Ryukemeister commented Sep 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Uh oh!

vercel Bot commented Sep 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Next.js Bundle Analysis for @calcom/web

Uh oh!

deploysentinel Bot commented Sep 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current Playwright Test Results Summary

⚠️ Flakes

Test Case Results

Test Case Results

Uh oh!

Uh oh!

supalarry left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Ryukemeister Oct 27, 2023

Choose a reason for hiding this comment

Uh oh!

supalarry Oct 27, 2023

Choose a reason for hiding this comment

Uh oh!

Ryukemeister Oct 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Ryukemeister Oct 30, 2023

Choose a reason for hiding this comment

Uh oh!

supalarry Oct 30, 2023

Choose a reason for hiding this comment

Uh oh!

PeerRich commented Nov 2, 2023

Uh oh!

Ryukemeister commented Nov 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

PeerRich commented Nov 9, 2023

Uh oh!

Ryukemeister commented Nov 9, 2023

Uh oh!

github-actions Bot commented Dec 8, 2023

Uh oh!

github-actions Bot commented Dec 16, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Ryukemeister commented Sep 29, 2023 •

edited

Loading

vercel Bot commented Sep 29, 2023 •

edited

Loading

github-actions Bot commented Sep 29, 2023 •

edited

Loading

github-actions Bot commented Sep 29, 2023 •

edited

Loading

deploysentinel Bot commented Sep 29, 2023 •

edited

Loading

Ryukemeister Oct 27, 2023 •

edited

Loading

Ryukemeister commented Nov 2, 2023 •

edited

Loading