fix: Wrong propagation clicking on globe icon in upcoming bookings page (CALCOM-11680)#11681
Merged
keithwillcode merged 4 commits intomainfrom Oct 11, 2023
Merged
fix: Wrong propagation clicking on globe icon in upcoming bookings page (CALCOM-11680)#11681keithwillcode merged 4 commits intomainfrom
keithwillcode merged 4 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Contributor
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes! |
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 147 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 10/10/2023 06:33:47pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: a85d785 Started: 10/10/2023 06:31:32pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Teams Profile page is loaded for users in Organization
Retry 2 • Retry 1 • Initial Attempt |
2.61% (7)7 / 268 runsfailed over last 7 days |
27.61% (74)74 / 268 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
2.82% (8)8 / 284 runsfailed over last 7 days |
11.27% (32)32 / 284 runsflaked over last 7 days |
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
3.53% (10)10 / 283 runsfailed over last 7 days |
94.70% (268)268 / 283 runsflaked over last 7 days |
📄 apps/web/playwright/managed-event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Managed Event Types tests Can create managed event type
Retry 1 • Initial Attempt |
1.41% (4)4 / 284 runsfailed over last 7 days |
26.06% (74)74 / 284 runsflaked over last 7 days |
gitstart-calcom
requested review from
Udit-takkar,
hariombalhara,
keithwillcode and
sean-brydon
and removed request for
hariombalhara
Contributor
ThyMinimalDev
left a comment
ThyMinimalDev
left a comment
There was a problem hiding this comment.
this implementation works, but It's worth checking if using
event.nativeEvent.preventDefault() instead of wrapping the trigger in a div fix the issue.
Contributor
|
@ThyMinimalDev We pushed the changes, please take a look again |
ThyMinimalDev
approved these changes
Oct 11, 2023
zomars
pushed a commit
that referenced
this pull request
Oct 11, 2023
Co-authored-by: gitstart-calcom <gitstart-calcom@users.noreply.github.com> Co-authored-by: GitStart-Cal.com <121884634+gitstart-calcom@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEMO
https://www.loom.com/share/7a742024741d49248aaf977b716a98cc?sid=2b4d6dda-d988-4eda-9d1b-d8eb1853b455