Skip to content

fix: API cold boot issues#11740

Merged
emrysal merged 1 commit intomainfrom
fix/11739-api-cold-boot-issues
Oct 6, 2023
Merged

fix: API cold boot issues#11740
emrysal merged 1 commit intomainfrom
fix/11739-api-cold-boot-issues

Conversation

@keithwillcode
Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes #11739

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Run all of these endpoints and ensure the functionality has not regressed

@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2023 5:15pm
api ❌ Failed (Inspect) Oct 6, 2023 5:15pm
cal-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2023 5:15pm
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2023 5:15pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2023 5:15pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Oct 6, 2023 5:15pm

@github-actions github-actions Bot added api area: API, enterprise API, access token, OAuth High priority Created by Linear-GitHub Sync linear Sync Github Issue from community members to Linear.app performance area: performance, page load, slow, slow endpoints, loading screen, unresponsive 🐛 bug Something isn't working labels Oct 6, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 6, 2023

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 6, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link
Copy Markdown

deploysentinel Bot commented Oct 6, 2023

Current Playwright Test Results Summary

✅ 146 Passing - ⚠️ 6 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 10/06/2023 05:18:13pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: e2961ac

Started: 10/06/2023 05:15:37pm UTC

⚠️ Flakes

📄   apps/web/playwright/login.2fa.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 1Initial Attempt
1.89% (5) 5 / 264 runs
failed over last 7 days
35.98% (95) 95 / 264 runs
flaked over last 7 days

📄   apps/web/playwright/reschedule.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Reschedule Tests Should do a reschedule from user owner
Retry 1Initial Attempt
0.36% (1) 1 / 279 run
failed over last 7 days
5.38% (15) 15 / 279 runs
flaked over last 7 days

📄   apps/web/playwright/profile.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Teams Profile page is loaded for users in Organization
Retry 1Initial Attempt
2.67% (6) 6 / 225 runs
failed over last 7 days
28% (63) 63 / 225 runs
flaked over last 7 days

📄   apps/web/playwright/managed-event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Managed Event Types tests Can create managed event type
Retry 1Initial Attempt
2.45% (7) 7 / 286 runs
failed over last 7 days
22.38% (64) 64 / 286 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 1Initial Attempt
3.53% (10) 10 / 283 runs
failed over last 7 days
93.99% (266) 266 / 283 runs
flaked over last 7 days

📄   apps/web/playwright/change-password.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Change Password Test change password
Retry 1Initial Attempt
0% (0) 0 / 280 runs
failed over last 7 days
1.07% (3) 3 / 280 runs
flaked over last 7 days

View Detailed Build Results


@emrysal emrysal merged commit 8a8d284 into main Oct 6, 2023
@emrysal emrysal deleted the fix/11739-api-cold-boot-issues branch October 6, 2023 18:17
@keithwillcode
Copy link
Copy Markdown
Contributor Author

@emrysal the api build was failing due to type errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api area: API, enterprise API, access token, OAuth 🐛 bug Something isn't working core area: core, team members only High priority Created by Linear-GitHub Sync linear Sync Github Issue from community members to Linear.app performance area: performance, page load, slow, slow endpoints, loading screen, unresponsive

Projects

None yet

Development

Successfully merging this pull request may close these issues.

API can have extremely slow cold boots due to tRPC router being imported

3 participants