Skip to content

fix: [CAL-2612] missing icon: request reschedule fixed #11829#11836

Merged
PeerRich merged 1 commit intocalcom:mainfrom
Abhinav-Developer-23:bugfix-missing-icon-request-reschedule-fix
Oct 11, 2023
Merged

fix: [CAL-2612] missing icon: request reschedule fixed #11829#11836
PeerRich merged 1 commit intocalcom:mainfrom
Abhinav-Developer-23:bugfix-missing-icon-request-reschedule-fix

Conversation

@Abhinav-Developer-23
Copy link
Copy Markdown
Contributor

@Abhinav-Developer-23 Abhinav-Developer-23 commented Oct 11, 2023

What does this PR do?

This PR fixes #11829 . The clock icon was not visible due to white background.I changed the background colour to other items in the same list.

Fixes #11829

Loom Video: https://www.loom.com/share/eced1e9baa3940dba5e0576a9fa20180?sid=c5a2b77f-5bf2-4ed5-b0b9-3a456bfd2675

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

Click on the "request reschedule" button and check the icon to test

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 11, 2023

@Abhinav-Developer-23 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2023 5:32pm

@github-actions github-actions Bot added Low priority Created by Linear-GitHub Sync ui area: UI, frontend, button, form, input ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work ✅ good first issue Good for newcomers labels Oct 11, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 11, 2023

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

@github-actions
Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@PeerRich
Copy link
Copy Markdown
Member

awesome, can you do the same change in ChargeCardDialog.tsx too?

@PeerRich PeerRich merged commit 916ee66 into calcom:main Oct 11, 2023
Abhinav-Developer-23 added a commit to Abhinav-Developer-23/cal.com that referenced this pull request Oct 12, 2023
@Abhinav-Developer-23
Copy link
Copy Markdown
Contributor Author

@PeerRich created a PR for credit card icon here #11846

@Abhinav-Developer-23
Copy link
Copy Markdown
Contributor Author

Sorry for the revert message above. I clicked on revert by mistake.Nothing has changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✅ good first issue Good for newcomers Low priority Created by Linear-GitHub Sync ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work ui area: UI, frontend, button, form, input

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-2612] missing icon: request reschedule

2 participants