Skip to content

fix(prisma): don't declare prisma as a global object and explicitly import it#11839

Merged
PeerRich merged 4 commits intocalcom:mainfrom
danielroe:fix/prisma
Oct 11, 2023
Merged

fix(prisma): don't declare prisma as a global object and explicitly import it#11839
PeerRich merged 4 commits intocalcom:mainfrom
danielroe:fix/prisma

Conversation

@danielroe
Copy link
Copy Markdown
Contributor

@danielroe danielroe commented Oct 11, 2023

What does this PR do?

related to #11837, this PR removes augmentation of global to add prisma property to make implicit use of prisma a type error. It also detects a bug where this was being used in the salesforce connector.

closes #11837 (as it includes it)

Requirement/Documentation

  • If there is a requirement document, please, share it here.
  • If there is ab UI/UX design document, please, share it here.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 11, 2023

@danielroe is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2023 8:42pm

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 11, 2023

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

@github-actions
Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@PeerRich PeerRich requested a review from zomars October 11, 2023 22:36
@PeerRich PeerRich added ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work High priority Created by Linear-GitHub Sync labels Oct 11, 2023
@PeerRich PeerRich merged commit 833fe7c into calcom:main Oct 11, 2023
@danielroe danielroe deleted the fix/prisma branch October 12, 2023 05:34
@zomars zomars mentioned this pull request Oct 12, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High priority Created by Linear-GitHub Sync ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants