feat: Weekly calendar event border color#11907
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes! |
sean-brydon
changed the title
| disabled?: boolean; | ||
| }; | ||
|
|
||
| const eventClasses = cva( |
There was a problem hiding this comment.
Using CVA for this as its less complicated than what we had
| {event.title} | ||
| </div> | ||
| {eventDuration >= 30 && ( | ||
| {eventDuration > 30 && ( |
There was a problem hiding this comment.
30 min time slots were being cut off from overflow. Removing the displayed time if the event is 30mins and only show > than
| const borderColor = options?.borderColor ? "custom" : options?.status; | ||
|
|
||
| const styles = options?.borderColor | ||
| ? { | ||
| borderColor: options?.borderColor, | ||
| } | ||
| : {}; |
There was a problem hiding this comment.
Use a "custom" border prop that applies 0 styling L:38
Allowing us to use the dynamic styles
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 154 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 10/16/2023 11:44:45am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: f7b22df Started: 10/16/2023 11:42:25am UTC
|
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 2 • Retry 1 • Initial Attempt |
7.69% (24)24 / 312 runsfailed over last 7 days |
91.03% (284)284 / 312 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
3.19% (10)10 / 313 runsfailed over last 7 days |
37.70% (118)118 / 313 runsflaked over last 7 days |
📄 apps/web/playwright/teams.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Teams Non admin team members cannot create team in org
Retry 1 • Initial Attempt |
20% (2)2 / 10 runsfailed over last 7 days |
30% (3)3 / 10 runsflaked over last 7 days |
sean-brydon
force-pushed
the
10-15-stack-troubleshooter-border-color-support
branch
from
706bbbd to
8013786
Compare
Udit-takkar
deleted the
10-15-stack-troubleshooter-border-color-support
branch
3 participants
Smaller PR seperated from the stack that is safe to merge by its self.
Adds basic support for custom colors for the up coming troubleshooter that uses calendar view
Safe PR that removes the times displayed for 30 mins events
adds support for a custom border color in events
Figma: https://www.figma.com/file/UajFu4M1APhn2AywAEJkJr/New-Features?type=design&node-id=5966-558456&mode=design