fix: unlock limit tab for managed event types#11936
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
github-actions
Bot
added
event types
Contributor
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes! |
Current Playwright Test Results Summary✅ 153 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 10/17/2023 09:36:41am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: f5832ee Started: 10/17/2023 09:33:33am UTC
|
|
|
13 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
unauthorized user sees correct translations (de) should use correct translations and html attributes
Retry 1 • Initial Attempt |
-125.61% (-103)-103 / 82 runsfailed over last 7 days |
125.61% (103)103 / 82 runsflaked over last 7 days |
|
unauthorized user sees correct translations (ar) should use correct translations and html attributes
Retry 1 • Initial Attempt |
-125.61% (-103)-103 / 82 runsfailed over last 7 days |
125.61% (103)103 / 82 runsflaked over last 7 days |
|
unauthorized user sees correct translations (zh) should use correct translations and html attributes
Retry 1 • Initial Attempt |
-26.32% (-5)-5 / 19 runsfailed over last 7 days |
31.58% (6)6 / 19 runsflaked over last 7 days |
|
unauthorized user sees correct translations (zh-CN) should use correct translations and html attributes
Retry 1 • Initial Attempt |
-33.33% (-6)-6 / 18 runsfailed over last 7 days |
33.33% (6)6 / 18 runsflaked over last 7 days |
|
unauthorized user sees correct translations (zh-TW) should use correct translations and html attributes
Retry 1 • Initial Attempt |
-33.33% (-6)-6 / 18 runsfailed over last 7 days |
33.33% (6)6 / 18 runsflaked over last 7 days |
|
unauthorized user sees correct translations (pt) should use correct translations and html attributes
Retry 1 • Initial Attempt |
-33.33% (-6)-6 / 18 runsfailed over last 7 days |
33.33% (6)6 / 18 runsflaked over last 7 days |
|
unauthorized user sees correct translations (pt-br) should use correct translations and html attributes
Retry 1 • Initial Attempt |
-33.33% (-6)-6 / 18 runsfailed over last 7 days |
33.33% (6)6 / 18 runsflaked over last 7 days |
|
unauthorized user sees correct translations (es-419) should use correct translations and html attributes
Retry 1 • Initial Attempt |
-33.33% (-6)-6 / 18 runsfailed over last 7 days |
33.33% (6)6 / 18 runsflaked over last 7 days |
|
authorized user sees correct translations (de) should return correct translations and html attributes
Retry 1 • Initial Attempt |
-22.22% (-4)-4 / 18 runsfailed over last 7 days |
22.22% (4)4 / 18 runsflaked over last 7 days |
|
authorized user sees correct translations (pt-br) should return correct translations and html attributes
Retry 1 • Initial Attempt |
-11.11% (-2)-2 / 18 runsfailed over last 7 days |
22.22% (4)4 / 18 runsflaked over last 7 days |
|
authorized user sees correct translations (ar) should return correct translations and html attributes
Retry 1 • Initial Attempt |
-36.36% (-12)-12 / 33 runsfailed over last 7 days |
72.73% (24)24 / 33 runsflaked over last 7 days |
|
authorized user sees changed translations (de->ar) should return correct translations and html attributes
Retry 1 • Initial Attempt |
-109.52% (-23)-23 / 21 runsfailed over last 7 days |
109.52% (23)23 / 21 runsflaked over last 7 days |
|
authorized user sees changed translations (de->pt-BR) [locale1] should return correct translations and html attributes
Retry 1 • Initial Attempt |
-20% (-3)-3 / 15 runsfailed over last 7 days |
26.67% (4)4 / 15 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
3.70% (11)11 / 297 runsfailed over last 7 days |
42.76% (127)127 / 297 runsflaked over last 7 days |
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
9.12% (27)27 / 296 runsfailed over last 7 days |
89.53% (265)265 / 296 runsflaked over last 7 days |
📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Routing Link should validate fields
Retry 1 • Initial Attempt |
0% (0)0 / 291 runsfailed over last 7 days |
10.65% (31)31 / 291 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 1 • Initial Attempt |
3.74% (11)11 / 294 runsfailed over last 7 days |
11.90% (35)35 / 294 runsflaked over last 7 days |
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
PeerRich
approved these changes
Oct 17, 2023
Member
PeerRich
left a comment
PeerRich
left a comment
There was a problem hiding this comment.
looks good! only code removed afaik
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We want to have all fields in the limit tab unlocked for managed event types. In v2 admins will be able to define themselves which fields should be locked and unlocked.
Fixes #11882
Type of change
How should this be tested?