chore: [app dir bootstrapping 10] adds ab tests middleware#12045
Merged
zomars merged 1 commit intocalcom:mainfrom Nov 15, 2023
codemod:dmytro/int-2029-manage-pagesapp-router-with-feature-flags-inside-of-the
Merged
chore: [app dir bootstrapping 10] adds ab tests middleware#12045zomars merged 1 commit intocalcom:mainfrom codemod:dmytro/int-2029-manage-pagesapp-router-with-feature-flags-inside-of-the
zomars merged 1 commit intocalcom:mainfrom
codemod:dmytro/int-2029-manage-pagesapp-router-with-feature-flags-inside-of-the
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@DmytroHryshyn is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes! |
dmytro068
changed the title
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
4 tasks
zomars
reviewed
Oct 26, 2023
Comment on lines
+327
to
+329
| "ZOOM_CLIENT_SECRET", | ||
| "AB_TEST_BUCKET_PROBABILITY", | ||
| "APP_ROUTER_EVENT_TYPES_ENABLED" |
Contributor
There was a problem hiding this comment.
NIT: Let's put these in alphabetical order
jakazzy
pushed a commit
to jakazzy/cal.com
that referenced
this pull request
Dec 5, 2023
) ## What does this PR do? - Adds AB tests middleware that redirects users to the app-dir pages with probability that is defined by env var <!-- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. --> Fixes # (issue) <!-- Please provide a loom video for visual changes to speed up reviews Loom Video: https://www.loom.com/ --> ## Requirement/Documentation <!-- Please provide all documents that are important to understand the reason of that PR. --> This PR requires new env variables: `APP_ROUTER_EVENT_TYPES_ENABLED` - boolean that defines if app dir event-types page redirect is enabled `AB_TEST_BUCKET_PROBABILITY` - number [0, 100] that defines the percentage of users getting redirected to the app dir pages ## Type of change <!-- Please delete bullets that are not relevant. --> - [ ] Bug fix (non-breaking change which fixes an issue) - [x] Chore (refactoring code, technical debt, workflow improvements) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ## How should this be tested? <!-- Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Write details that help to start the tests --> Does not requires testing, implements middleware as a dead code ## Mandatory Tasks - [x] Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.
zomars
pushed a commit
that referenced
this pull request
Jan 29, 2024
## What does this PR do? - Adds AB tests middleware that redirects users to the app-dir pages with probability that is defined by env var <!-- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. --> Fixes # (issue) <!-- Please provide a loom video for visual changes to speed up reviews Loom Video: https://www.loom.com/ --> ## Requirement/Documentation <!-- Please provide all documents that are important to understand the reason of that PR. --> This PR requires new env variables: `APP_ROUTER_EVENT_TYPES_ENABLED` - boolean that defines if app dir event-types page redirect is enabled `AB_TEST_BUCKET_PROBABILITY` - number [0, 100] that defines the percentage of users getting redirected to the app dir pages ## Type of change <!-- Please delete bullets that are not relevant. --> - [ ] Bug fix (non-breaking change which fixes an issue) - [x] Chore (refactoring code, technical debt, workflow improvements) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ## How should this be tested? <!-- Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Write details that help to start the tests --> Does not requires testing, implements middleware as a dead code ## Mandatory Tasks - [x] Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue)
Requirement/Documentation
This PR requires new env variables:
APP_ROUTER_EVENT_TYPES_ENABLED- boolean that defines if app dir event-types page redirect is enabledAB_TEST_BUCKET_PROBABILITY- number [0, 100] that defines the percentage of users getting redirected to the app dir pagesType of change
How should this be tested?
Does not requires testing, implements middleware as a dead code
Mandatory Tasks