Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
Contributor
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes! |
hariombalhara
commented
Oct 25, 2023
| calLink: string; | ||
| queryObject?: PrefillAndIframeAttrsConfig & { guest?: string | string[] }; | ||
| calOrigin?: string; | ||
| calOrigin: string | null; |
Member
Author
There was a problem hiding this comment.
Make it required so that it's never missed
hariombalhara
commented
Oct 25, 2023
| const iframe = this.cal.createIframe({ | ||
| calLink, | ||
| queryObject: withColorScheme(Cal.getQueryObject(config), containerEl), | ||
| calOrigin: calConfig.calOrigin, |
Member
Author
There was a problem hiding this comment.
Even though createIframe fallbacks to it, but it's better to be explcit.
hariombalhara
commented
Oct 25, 2023
| iframe = this.cal.createIframe({ | ||
| calLink, | ||
| queryObject, | ||
| calOrigin: calOrigin || null, |
Member
Author
There was a problem hiding this comment.
This is what actually fixes the bug.
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
hariombalhara
changed the title
Current Playwright Test Results Summary✅ 208 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 10/25/2023 05:41:29am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: bfe32dc Started: 10/25/2023 05:38:09am UTC
|
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests user has at least 2 events
Retry 1 • Initial Attempt |
0% (0)0 / 283 runsfailed over last 7 days |
0.35% (1)1 / 283 runflaked over last 7 days |
|
Event Types tests user can add new event type
Retry 1 • Initial Attempt |
0% (0)0 / 283 runsfailed over last 7 days |
1.06% (3)3 / 283 runsflaked over last 7 days |
📄 apps/web/playwright/login.2fa.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 1 • Initial Attempt |
0% (0)0 / 273 runsfailed over last 7 days |
29.30% (80)80 / 273 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
0% (0)0 / 282 runsfailed over last 7 days |
45.74% (129)129 / 282 runsflaked over last 7 days |
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
6.76% (19)19 / 281 runsfailed over last 7 days |
90.75% (255)255 / 281 runsflaked over last 7 days |
📄 apps/web/playwright/profile.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Teams Profile page is loaded for users in Organization
Retry 1 • Initial Attempt |
0% (0)0 / 274 runsfailed over last 7 days |
33.21% (91)91 / 274 runsflaked over last 7 days |
📄 apps/web/playwright/webhook.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
FORM_SUBMITTED on submitting team form, triggers team webhook
Retry 1 • Initial Attempt |
0% (0)0 / 276 runsfailed over last 7 days |
11.59% (32)32 / 276 runsflaked over last 7 days |
hariombalhara
changed the title
PeerRich
approved these changes
Nov 2, 2023
zomars
pushed a commit
that referenced
this pull request
Jan 29, 2024
…lement click popup and floating button popup) (#12075)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #12073
Type of change
How should this be tested?
Set
data-cal-originon the element click popup button and see that the cal link is still being opened from default app.cal.local:3000 and not the provided valueMandatory Tasks
Checklist