Skip to content

feat: The 'confirm' button triggers after entering the code#12128

Merged
PeerRich merged 10 commits intocalcom:mainfrom
siddharth-movaliya:cal/automaticOTP
Nov 3, 2023
Merged

feat: The 'confirm' button triggers after entering the code#12128
PeerRich merged 10 commits intocalcom:mainfrom
siddharth-movaliya:cal/automaticOTP

Conversation

@siddharth-movaliya
Copy link
Copy Markdown
Contributor

@siddharth-movaliya siddharth-movaliya commented Oct 28, 2023

What does this PR do?

Users no longer need to click on confirm after entering the 6-digit code for bookings with booker email confirmation required event-types.

Fixes #12127

Type of change

  • New feature (non-breaking change which adds functionality)

How should this be tested?

  1. Go to booking page of an event-type that has booker email verification turned on. Select a time slot and click on verify. Once you enter the 6-digit code, you'll no longer need to click on confirm.

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 28, 2023

@Siddharth-2382 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 28, 2023

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

@github-actions github-actions Bot added ✨ feature New feature or request 🐛 bug Something isn't working 🧹 Improvements Improvements to existing features. Mostly UX/UI labels Oct 28, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 28, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@siddharth-movaliya
Copy link
Copy Markdown
Contributor Author

I totally misunderstood verify button for confirm. I'll fix it tomorrow in the morning.

@siddharth-movaliya
Copy link
Copy Markdown
Contributor Author

@PeerRich

Screen.Recording.2023-11-01.at.2.07.50.PM.mov

@PeerRich PeerRich added the Medium priority Created by Linear-GitHub Sync label Nov 2, 2023
@PeerRich PeerRich removed the 🐛 bug Something isn't working label Nov 2, 2023
@PeerRich PeerRich merged commit 23fda4a into calcom:main Nov 3, 2023
@siddharth-movaliya siddharth-movaliya deleted the cal/automaticOTP branch November 3, 2023 11:50
zomars pushed a commit that referenced this pull request Jan 29, 2024
Co-authored-by: Peer Richelsen <peeroke@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ feature New feature or request 🧹 Improvements Improvements to existing features. Mostly UX/UI Medium priority Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-2657] verify email: the "confirm" button should trigger after entering the code

2 participants