feat: multi round robin hosts#12169
Conversation
|
@david-m-l21s is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
|
|
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes! |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! Eighty-six Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
|
ahhh so instead of one random it selects N random people that must join? |
|
@david-m-l21s really nice work on this! Curious is this solving an existing need you have in the product for this feature and if you could elaborate on the scnerio if you don't mind 🙏? |
|
Hey there, there is a merge conflict, can you take a look? |
github-actions
Bot
added
the
🚨 merge conflict
Yes exactly.
Sure. The reason we approached this is that we have many meetings (for now mostly recruitment) where we want to apply the "4 eyes principle" and thereby at least 2 poeple from the team should participate. Obviously setting this up manually is tedious. The Round-Robin behavior in cal.com would solve that issue except that it works just for one RoundRobin participant. With the changes in this PR we are almost were we want to be. |
|
@david-m-l21s thank you for clarifying. That makes perfect sense. Very interesting use case and sounds like something that would be great to have in the product 👍 |
…_robin # Conflicts: # packages/core/getAggregatedAvailability.ts
PeerRich
removed
the
🚨 merge conflict
PeerRich
added
✨ feature
|
This PR is being marked as stale due to inactivity. |
…_robin # Conflicts: # apps/web/pages/api/auth/signup.ts # apps/web/pages/signup.tsx # apps/web/playwright/signup.e2e.ts
…_robin # Conflicts: # apps/web/app/future/(shared-page-wrapper)/(settings-layout)/settings/admin/organizations/page.tsx # apps/web/app/future/(shared-page-wrapper)/(settings-layout)/settings/admin/users/[id]/edit/page.tsx # apps/web/app/future/(shared-page-wrapper)/(settings-layout)/settings/admin/users/add/page.tsx # apps/web/app/future/(shared-page-wrapper)/(settings-layout)/settings/admin/users/page.tsx
|
This PR is being marked as stale due to inactivity. |
|
Hey guys, this looks super interesting! Would love to see this merged |
|
This PR is being marked as stale due to inactivity. |
|
Closing for now since the resolve conflict list is quite long. If able to address, let's reopen this then. |
7 participants
What does this PR do?
Adds the possibility to select several round-robin-hosts for the respective event-type.
Fixes # 11953
Crucial changes which were necessary:
1. Frontend:
Adds an input-field to the Event-Team-Tab by which the number of round-robin hosts which need to participate
in the event can be specified
2. Availability:
For multiple round-robin-hosts the way how the collective availability is determined needs to be changed.
3. Select the correct number of hosts in the booking-handler
Type of change
How should this be tested?
A test is provided in the PR.