Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
Contributor
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes! |
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 40 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 11/01/2023 08:26:21pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 274598c Started: 11/01/2023 08:23:28pm UTC
|
|
|
13 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
unauthorized user sees correct translations (de) should use correct translations and html attributes
Retry 1 • Initial Attempt |
-13.49% (-41)-41 / 304 runsfailed over last 7 days |
13.49% (41)41 / 304 runsflaked over last 7 days |
|
unauthorized user sees correct translations (ar) should use correct translations and html attributes
Retry 1 • Initial Attempt |
-13.49% (-41)-41 / 304 runsfailed over last 7 days |
13.49% (41)41 / 304 runsflaked over last 7 days |
|
unauthorized user sees correct translations (zh) should use correct translations and html attributes
Retry 1 • Initial Attempt |
-13.49% (-41)-41 / 304 runsfailed over last 7 days |
13.49% (41)41 / 304 runsflaked over last 7 days |
|
unauthorized user sees correct translations (zh-CN) should use correct translations and html attributes
Retry 1 • Initial Attempt |
-13.49% (-41)-41 / 304 runsfailed over last 7 days |
13.49% (41)41 / 304 runsflaked over last 7 days |
|
unauthorized user sees correct translations (zh-TW) should use correct translations and html attributes
Retry 1 • Initial Attempt |
-13.16% (-40)-40 / 304 runsfailed over last 7 days |
13.49% (41)41 / 304 runsflaked over last 7 days |
|
unauthorized user sees correct translations (pt) should use correct translations and html attributes
Retry 1 • Initial Attempt |
-13.53% (-41)-41 / 303 runsfailed over last 7 days |
13.53% (41)41 / 303 runsflaked over last 7 days |
|
unauthorized user sees correct translations (pt-br) should use correct translations and html attributes
Retry 1 • Initial Attempt |
-13.53% (-41)-41 / 303 runsfailed over last 7 days |
13.53% (41)41 / 303 runsflaked over last 7 days |
|
unauthorized user sees correct translations (es-419) should use correct translations and html attributes
Retry 1 • Initial Attempt |
-13.20% (-40)-40 / 303 runsfailed over last 7 days |
13.53% (41)41 / 303 runsflaked over last 7 days |
|
authorized user sees correct translations (de) should return correct translations and html attributes
Retry 1 • Initial Attempt |
-11.30% (-34)-34 / 301 runsfailed over last 7 days |
13.62% (41)41 / 301 runsflaked over last 7 days |
|
authorized user sees correct translations (pt-br) should return correct translations and html attributes
Retry 1 • Initial Attempt |
-11.56% (-34)-34 / 294 runsfailed over last 7 days |
13.95% (41)41 / 294 runsflaked over last 7 days |
|
authorized user sees correct translations (ar) should return correct translations and html attributes
Retry 1 • Initial Attempt |
-13.94% (-40)-40 / 287 runsfailed over last 7 days |
14.29% (41)41 / 287 runsflaked over last 7 days |
|
authorized user sees changed translations (de->pt-BR) [locale1] should return correct translations and html attributes
Retry 1 • Initial Attempt |
-9.45% (-26)-26 / 275 runsfailed over last 7 days |
13.09% (36)36 / 275 runsflaked over last 7 days |
|
authorized user sees changed translations (de->ar) should return correct translations and html attributes
Retry 1 • Initial Attempt |
-9.79% (-28)-28 / 286 runsfailed over last 7 days |
13.64% (39)39 / 286 runsflaked over last 7 days |
📄 apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Stripe integration Pending payment booking should not be confirmed by default
Retry 1 • Initial Attempt |
2.84% (9)9 / 317 runsfailed over last 7 days |
4.42% (14)14 / 317 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests user can add multiple organizer address
Retry 1 • Initial Attempt |
0.96% (3)3 / 311 runsfailed over last 7 days |
9.32% (29)29 / 311 runsflaked over last 7 days |
Udit-takkar
commented
Nov 1, 2023
Comment on lines
-264
to
-265
| const checkForRecordingsButton = | ||
| !showRecordingsButtons && (booking.location === "integrations:daily" || booking?.location?.trim() === ""); |
Contributor
Author
There was a problem hiding this comment.
completely removing it
keithwillcode
previously requested changes
Nov 1, 2023
Contributor
keithwillcode
left a comment
keithwillcode
left a comment
There was a problem hiding this comment.
Let’s add an E2E test to verify this doesn’t regress again
CarinaWolli
approved these changes
Nov 1, 2023
Contributor
Author
|
@keithwillcode this won't happen again because I have removed the button completely 😆 as suggested by peer |
PeerRich
approved these changes
Nov 1, 2023
PeerRich
previously requested changes
Nov 1, 2023
Member
PeerRich
left a comment
PeerRich
left a comment
There was a problem hiding this comment.
actually lemme also test on dev
Member
|
some checks failing @Udit-takkar |
Contributor
Author
they are not related to this PR. can you retrigger them> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12179