Skip to content

fix: API to return hosts on event types response#12204

Merged
PeerRich merged 4 commits intomainfrom
fix/api-return-hosts-on-event-types-response
Nov 3, 2023
Merged

fix: API to return hosts on event types response#12204
PeerRich merged 4 commits intomainfrom
fix/api-return-hosts-on-event-types-response

Conversation

@alishaz-polymath
Copy link
Copy Markdown
Member

What does this PR do?

  • The event types _get and /[id]/_get now returns hosts for team event types, in the format:
    "hosts": [
        {
            "isFixed": false,
            "userId": 123
        },
        {
            "isFixed": false,
            "userId": 456
        }
    ]

Fixes #12190

Requirement/Documentation

  • NA

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • GET /event-types/[id] & /event-types/ API requests should now return with an array of hosts filled in for team event types with hosts set, unlike earlier when it would always be empty.

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 3, 2023 6:35am
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 3, 2023 6:35am
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 3, 2023 6:35am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Nov 3, 2023 6:35am
cal-demo ⬜️ Ignored (Inspect) Nov 3, 2023 6:35am
qa ⬜️ Ignored (Inspect) Visit Preview Nov 3, 2023 6:35am
ui ⬜️ Ignored (Inspect) Visit Preview Nov 3, 2023 6:35am

@alishaz-polymath alishaz-polymath requested a review from a team November 2, 2023 13:09
@github-actions github-actions Bot added ✨ feature New feature or request 🚨 needs approval This feature request has not been reviewed yet by the Product Team and needs approval beforehand labels Nov 2, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 2, 2023

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

@zomars zomars added the core area: core, team members only label Nov 2, 2023
@alishaz-polymath alishaz-polymath added api area: API, enterprise API, access token, OAuth and removed 🚨 needs approval This feature request has not been reviewed yet by the Product Team and needs approval beforehand labels Nov 2, 2023
@alishaz-polymath alishaz-polymath changed the title Fix: API to return hosts on event types response fix: API to return hosts on event types response Nov 2, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 2, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link
Copy Markdown

deploysentinel Bot commented Nov 2, 2023

Current Playwright Test Results Summary

✅ 13 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 11/03/2023 08:01:56am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: a060705

Started: 11/03/2023 08:01:29am UTC

⚠️ Flakes

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 1Initial Attempt
20.23% (53) 53 / 262 runs
failed over last 7 days
76.72% (201) 201 / 262 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1Initial Attempt
1.92% (5) 5 / 261 runs
failed over last 7 days
60.54% (158) 158 / 261 runs
flaked over last 7 days

View Detailed Build Results


@PeerRich PeerRich added the High priority Created by Linear-GitHub Sync label Nov 2, 2023
@ThyMinimalDev
Copy link
Copy Markdown
Contributor

LGTM

@PeerRich PeerRich merged commit ed04062 into main Nov 3, 2023
@PeerRich PeerRich deleted the fix/api-return-hosts-on-event-types-response branch November 3, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api area: API, enterprise API, access token, OAuth core area: core, team members only ✨ feature New feature or request High priority Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

API - return hosts on event-types response

4 participants