Skip to content

fix: Set the dateFrom to startOf day otherwise bad fromOffset is used#12210

Merged
emrysal merged 3 commits intomainfrom
bugfix/date-shift-negative-tz-on-dst
Nov 3, 2023
Merged

fix: Set the dateFrom to startOf day otherwise bad fromOffset is used#12210
emrysal merged 3 commits intomainfrom
bugfix/date-shift-negative-tz-on-dst

Conversation

@emrysal
Copy link
Copy Markdown
Contributor

@emrysal emrysal commented Nov 2, 2023

What does this PR do?

Fixed #12137

Added test to ensure fix works (fails before, passes after)

@emrysal emrysal requested a review from CarinaWolli November 2, 2023 16:39
@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 3, 2023 3:11am
cal-demo 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 3, 2023 3:11am
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 3, 2023 3:11am
qa 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 3, 2023 3:11am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview Nov 3, 2023 3:11am
cal ⬜️ Ignored (Inspect) Visit Preview Nov 3, 2023 3:11am
ui ⬜️ Ignored (Inspect) Visit Preview Nov 3, 2023 3:11am

@github-actions github-actions Bot added bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working labels Nov 2, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 2, 2023

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

@zomars zomars added the core area: core, team members only label Nov 2, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 2, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link
Copy Markdown

deploysentinel Bot commented Nov 2, 2023

Current Playwright Test Results Summary

✅ 251 Passing - ⚠️ 4 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 11/03/2023 03:12:24am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: f1b5f11

Started: 11/03/2023 03:08:50am UTC

⚠️ Flakes

📄   apps/web/playwright/teams.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Teams - NonOrg Non admin team members cannot create team in org
Retry 1Initial Attempt
0% (0) 0 / 208 runs
failed over last 7 days
29.81% (62) 62 / 208 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1Initial Attempt
1.96% (5) 5 / 255 runs
failed over last 7 days
60.39% (154) 154 / 255 runs
flaked over last 7 days
Popup Tests should be able to reschedule
Retry 2Retry 1Initial Attempt
20.31% (52) 52 / 256 runs
failed over last 7 days
76.56% (196) 196 / 256 runs
flaked over last 7 days

📄   apps/web/playwright/insights.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Insights should be able to go to insights as admins
Retry 1Initial Attempt
0% (0) 0 / 254 runs
failed over last 7 days
3.94% (10) 10 / 254 runs
flaked over last 7 days

View Detailed Build Results


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working core area: core, team members only High priority Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Availibility shown is not correct when minimum notice date lands on Nov 5 (DST change day)

4 participants