fix: Fix "Could not book the meeting" issue (fix-bookingIssue) by gitstart-app[bot] · Pull Request #12252 · calcom/cal.diy

gitstart-app · 2023-11-06T23:38:02Z

DEMO

https://www.loom.com/share/ccbb1d3c40954b6588000955dcc43612?sid=8fe6456a-6d13-4370-95b6-4a19b5a40413

tests:

vercel · 2023-11-06T23:38:04Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
ai	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 7, 2023 2:27pm
api	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 7, 2023 2:27pm
dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 7, 2023 2:27pm
qa	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Nov 7, 2023 2:27pm

3 Ignored Deployments

Name	Status	Preview	Updated (UTC)
cal	⬜️ Ignored (Inspect)	Visit Preview	Nov 7, 2023 2:27pm
cal-demo	⬜️ Ignored (Inspect)	Visit Preview	Nov 7, 2023 2:27pm
ui	⬜️ Ignored (Inspect)	Visit Preview	Nov 7, 2023 2:27pm

github-actions · 2023-11-06T23:38:15Z

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

github-actions · 2023-11-06T23:45:47Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

deploysentinel · 2023-11-06T23:46:27Z

Current Playwright Test Results Summary

✅ 313 Passing - ⚠️ 7 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 11/07/2023 02:35:30pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 47a37a4

Started: 11/07/2023 02:24:27pm UTC

⚠️ Flakes

📄 apps/web/playwright/login.2fa.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
2FA Tests should allow a user to enable 2FA and login using 2FA Retry 1 • Initial Attempt	0.45% (1) 1 / 224 run failed over last 7 days	30.36% (68) 68 / 224 runs flaked over last 7 days

📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes

Top 1 Common Error Messages

`null`	2 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Popup Tests should be able to reschedule Retry 1 • Initial Attempt	20.60% (48) 48 / 233 runs failed over last 7 days	73.82% (172) 172 / 233 runs flaked over last 7 days
Popup Tests should open embed iframe on click - Configured with light theme Retry 2 • Retry 1 • Initial Attempt	0.43% (1) 1 / 233 run failed over last 7 days	60.09% (140) 140 / 233 runs flaked over last 7 days

📄 apps/web/playwright/insights.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Insights should be able to switch between memberUsers Retry 1 • Initial Attempt	0% (0) 0 / 227 runs failed over last 7 days	1.32% (3) 3 / 227 runs flaked over last 7 days

📄 apps/web/playwright/teams.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Teams - NonOrg Non admin team members cannot create team in org Retry 1 • Initial Attempt	0% (0) 0 / 214 runs failed over last 7 days	40.19% (86) 86 / 214 runs flaked over last 7 days

📄 apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Event Types tests user Different Locations Tests Can add Link Meeting as location and book with it Retry 1 • Initial Attempt	0% (0) 0 / 226 runs failed over last 7 days	10.18% (23) 23 / 226 runs flaked over last 7 days

📄 apps/web/playwright/managed-event-types.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Managed Event Types tests Can create managed event type Retry 2 • Retry 1 • Initial Attempt	10.82% (25) 25 / 231 runs failed over last 7 days	12.99% (30) 30 / 231 runs flaked over last 7 days

View Detailed Build Results

keithwillcode

Nice find. Can we update the tests in date-ranges.test.ts to include tests for this change?

gitstart-calcom · 2023-11-07T13:23:01Z

@keithwillcode We have made sure that these changes do not affect any test, so these current tests will also cover this new change 😄.

keithwillcode · 2023-11-07T13:31:46Z

@gitstart-calcom My point is that if there were a unit test for the issue that is fixed in this PR, that unit test would have been failing this whole time. If logic like this changes and no tests fail, that's great, but it doesn't mean that we actually have a test that ensures this change in logic works and continues working.

Even if we have E2E tests to cover this, I prefer adding unit tests so we have verification at the root of the code.

gitstart-calcom · 2023-11-07T13:50:37Z

@keithwillcode Makes sense! We will add a unit test for that now!

…ingIssue

keithwillcode · 2023-11-07T14:18:39Z

+  it("should skip event if it ends before it starts (same day but different hours)", () => {
+    const item = {
+      days: [1],
+      startTime: new Date(new Date().setUTCHours(8, 0, 0, 0)), // 8 AM


@gitstart-calcom Thanks for adding these tests. Do we know how this happens? I'm just wondering how an end time would get set to be before a start time?

To be honest we got confused about how this can happen too. Also, the issue occurring just in the first available time-slot was really weird. This hypothetical situation may be the result of a data entry error or a bug in the application code. It could be a mistake in the way the data is being provided or manipulated before it reaches the processWorkingHours function. Maybe setting the endTime/dateTo before the startTime/dateFrom can cause this issue, but we don't see a scenario in which that happens

But now, with the specific tests and the new logic, we fixed the issue and we can identify a possible issue faster 😄

Cool yeah that's what I suspected myself. Seems like this function is being passed bad data for some reason.

gitstart-calcom · 2023-11-07T14:19:01Z

@keithwillcode We added 2 test lines for this case and added a screenshot in the description 😄

Co-authored-by: gitstart-calcom <gitstart-calcom@users.noreply.github.com>

Fix issue on schedule a meeting

a4c2e89

vercel Bot deployed to Preview – ai November 6, 2023 23:42 View deployment

vercel Bot deployed to Preview – api November 6, 2023 23:44 View deployment

vercel Bot deployed to Preview – dev November 6, 2023 23:48 View deployment

FIx failing tests

a4e9846

vercel Bot deployed to Preview – ai November 7, 2023 00:33 View deployment

vercel Bot deployed to Preview – api November 7, 2023 00:36 View deployment

vercel Bot deployed to Preview – dev November 7, 2023 00:36 View deployment

gitstart-calcom marked this pull request as ready for review November 7, 2023 00:51

gitstart-calcom requested review from emrysal, keithwillcode and sean-brydon November 7, 2023 00:52

gitstart-calcom self-assigned this Nov 7, 2023

keithwillcode added High priority Created by Linear-GitHub Sync bookings area: bookings, availability, timezones, double booking labels Nov 7, 2023

keithwillcode requested changes Nov 7, 2023

View reviewed changes

gitstart-calcom requested a review from keithwillcode November 7, 2023 13:24

gitstart-calcom added 2 commits November 7, 2023 14:15

Merge commit '13ec810cb992632f7fa12be90d9b11f391f00dda' into fix-book…

96d6ea3

…ingIssue

Add tests

47a37a4

keithwillcode reviewed Nov 7, 2023

View reviewed changes

vercel Bot deployed to Preview – dev November 7, 2023 14:23 View deployment

vercel Bot deployed to Preview – ai November 7, 2023 14:24 View deployment

vercel Bot deployed to Preview – api November 7, 2023 14:27 View deployment

keithwillcode approved these changes Nov 7, 2023

View reviewed changes

keithwillcode merged commit d28e20e into main Nov 7, 2023

keithwillcode deleted the fix-bookingIssue branch November 7, 2023 15:33

zomars pushed a commit that referenced this pull request Jan 29, 2024

fix: Fix "Could not book the meeting" issue (fix-bookingIssue) (#12252)

4f927ab

Co-authored-by: gitstart-calcom <gitstart-calcom@users.noreply.github.com>

Conversation

gitstart-app Bot commented Nov 6, 2023 • edited by gitstart-calcom Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

DEMO

Uh oh!

vercel Bot commented Nov 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Nov 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Nov 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Next.js Bundle Analysis for @calcom/web

Uh oh!

deploysentinel Bot commented Nov 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current Playwright Test Results Summary

⚠️ Flakes

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Uh oh!

keithwillcode left a comment

Choose a reason for hiding this comment

Uh oh!

gitstart-calcom commented Nov 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

keithwillcode commented Nov 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gitstart-calcom commented Nov 7, 2023

Uh oh!

keithwillcode Nov 7, 2023

Choose a reason for hiding this comment

Uh oh!

gitstart-calcom Nov 7, 2023

Choose a reason for hiding this comment

Uh oh!

gitstart-calcom Nov 7, 2023

Choose a reason for hiding this comment

Uh oh!

keithwillcode Nov 7, 2023

Choose a reason for hiding this comment

Uh oh!

gitstart-calcom commented Nov 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gitstart-app Bot commented Nov 6, 2023 •

edited by gitstart-calcom

Loading

vercel Bot commented Nov 6, 2023 •

edited

Loading

github-actions Bot commented Nov 6, 2023 •

edited

Loading

github-actions Bot commented Nov 6, 2023 •

edited

Loading

deploysentinel Bot commented Nov 6, 2023 •

edited

Loading

gitstart-calcom commented Nov 7, 2023 •

edited

Loading

keithwillcode commented Nov 7, 2023 •

edited

Loading