fix: payment cancel button redirects properly#12254
Merged
ThyMinimalDev merged 1 commit intomainfrom Nov 8, 2023
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes! |
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 313 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 11/07/2023 08:30:46am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 81fadcb Started: 11/07/2023 08:22:59am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests user Different Locations Tests can add Attendee Phone Number location and book with it
Retry 1 • Initial Attempt |
0.47% (1)1 / 215 runfailed over last 7 days |
6.05% (13)13 / 215 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 4 Flakes
Top 1 Common Error Messages
|
|
4 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
0.45% (1)1 / 220 runfailed over last 7 days |
60% (132)132 / 220 runsflaked over last 7 days |
|
Popup Tests should be able to reschedule
Retry 2 • Retry 1 • Initial Attempt |
20.91% (46)46 / 220 runsfailed over last 7 days |
73.64% (162)162 / 220 runsflaked over last 7 days |
|
Popup Tests should open Routing Forms embed on click
Retry 1 • Initial Attempt |
0% (0)0 / 220 runsfailed over last 7 days |
31.82% (70)70 / 220 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
0.45% (1)1 / 220 runfailed over last 7 days |
57.73% (127)127 / 220 runsflaked over last 7 days |
📄 apps/web/playwright/teams.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Teams - NonOrg Can create a private team
Retry 1 • Initial Attempt |
0.50% (1)1 / 202 runfailed over last 7 days |
15.35% (31)31 / 202 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 1 • Initial Attempt |
1.38% (3)3 / 217 runsfailed over last 7 days |
27.19% (59)59 / 217 runsflaked over last 7 days |
exception
approved these changes
Nov 7, 2023
sean-brydon
approved these changes
Nov 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2023-11-07.at.10.13.08.mov
What does this PR do?
This pr fixes the behavior of the cancel button on the booking payment page
Requirement/Documentation
Type of change
How should this be tested?
Mandatory Tasks
Checklist