Skip to content

fix: payment cancel button redirects properly#12254

Merged
ThyMinimalDev merged 1 commit intomainfrom
fix-payment-cancel-button
Nov 8, 2023
Merged

fix: payment cancel button redirects properly#12254
ThyMinimalDev merged 1 commit intomainfrom
fix-payment-cancel-button

Conversation

@ThyMinimalDev
Copy link
Copy Markdown
Contributor

@ThyMinimalDev ThyMinimalDev commented Nov 7, 2023

Screen.Recording.2023-11-07.at.10.13.08.mov

What does this PR do?

This pr fixes the behavior of the cancel button on the booking payment page

Requirement/Documentation

  • If there is a requirement document, please, share it here.
  • If there is ab UI/UX design document, please, share it here.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2023 8:24am
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2023 8:24am
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2023 8:24am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Nov 7, 2023 8:24am
cal-demo ⬜️ Ignored (Inspect) Nov 7, 2023 8:24am
ui ⬜️ Ignored (Inspect) Nov 7, 2023 8:24am

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 7, 2023

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 7, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link
Copy Markdown

deploysentinel Bot commented Nov 7, 2023

Current Playwright Test Results Summary

✅ 313 Passing - ⚠️ 7 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 11/07/2023 08:30:46am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 81fadcb

Started: 11/07/2023 08:22:59am UTC

⚠️ Flakes

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests user Different Locations Tests can add Attendee Phone Number location and book with it
Retry 1Initial Attempt
0.47% (1) 1 / 215 run
failed over last 7 days
6.05% (13) 13 / 215 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 4 Flakes

Top 1 Common Error Messages

null

4 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1Initial Attempt
0.45% (1) 1 / 220 run
failed over last 7 days
60% (132) 132 / 220 runs
flaked over last 7 days
Popup Tests should be able to reschedule
Retry 2Retry 1Initial Attempt
20.91% (46) 46 / 220 runs
failed over last 7 days
73.64% (162) 162 / 220 runs
flaked over last 7 days
Popup Tests should open Routing Forms embed on click
Retry 1Initial Attempt
0% (0) 0 / 220 runs
failed over last 7 days
31.82% (70) 70 / 220 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1Initial Attempt
0.45% (1) 1 / 220 run
failed over last 7 days
57.73% (127) 127 / 220 runs
flaked over last 7 days

📄   apps/web/playwright/teams.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Teams - NonOrg Can create a private team
Retry 1Initial Attempt
0.50% (1) 1 / 202 run
failed over last 7 days
15.35% (31) 31 / 202 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 1Initial Attempt
1.38% (3) 3 / 217 runs
failed over last 7 days
27.19% (59) 59 / 217 runs
flaked over last 7 days

View Detailed Build Results


@ThyMinimalDev ThyMinimalDev merged commit 1f98802 into main Nov 8, 2023
@ThyMinimalDev ThyMinimalDev deleted the fix-payment-cancel-button branch November 8, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants