Skip to content

fix: Remove count from query to update schedule#12287

Merged
keithwillcode merged 3 commits intomainfrom
fix/slowest-query
Nov 8, 2023
Merged

fix: Remove count from query to update schedule#12287
keithwillcode merged 3 commits intomainfrom
fix/slowest-query

Conversation

@keithwillcode
Copy link
Copy Markdown
Contributor

@keithwillcode keithwillcode commented Nov 8, 2023

What does this PR do?

Related to #10954, this fixes an extremely slow query that is being run quite a lot, especially considering we have a tRPC bug on the front end triggering lots of calls to update schedule.
54fab6b9-eab1-4271-a830-c6fdc88362d2

Type of change

  • Chore (refactoring code, technical debt, workflow improvements)

How should this be tested?

  • Ensure you can properly update schedules

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@keithwillcode keithwillcode requested a review from a team November 8, 2023 16:09
@keithwillcode keithwillcode self-assigned this Nov 8, 2023
@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2023 5:21pm
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2023 5:21pm
5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2023 5:21pm
cal ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2023 5:21pm
cal-demo ⬜️ Ignored (Inspect) Nov 8, 2023 5:21pm
qa ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2023 5:21pm
ui ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2023 5:21pm

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 8, 2023

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 8, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link
Copy Markdown

deploysentinel Bot commented Nov 8, 2023

Current Playwright Test Results Summary

✅ 13 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 11/08/2023 05:45:23pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 329cecd

Started: 11/08/2023 05:44:55pm UTC

⚠️ Flakes

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1Initial Attempt
0.42% (1) 1 / 238 run
failed over last 7 days
55.88% (133) 133 / 238 runs
flaked over last 7 days
Popup Tests should be able to reschedule
Retry 1Initial Attempt
20.17% (48) 48 / 238 runs
failed over last 7 days
73.95% (176) 176 / 238 runs
flaked over last 7 days

View Detailed Build Results


@keithwillcode keithwillcode merged commit 09fc7e1 into main Nov 8, 2023
@keithwillcode keithwillcode deleted the fix/slowest-query branch November 8, 2023 17:47
zomars pushed a commit that referenced this pull request Jan 29, 2024
Co-authored-by: Carina Wollendorfer <30310907+CarinaWolli@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

admin core area: core, team members only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants