fix: unhandled promise rejection in scheduleWorkflowReminder#12301
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
Contributor
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes! |
added 2 commits
November 9, 2023 11:17
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 313 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 11/13/2023 10:23:13pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: ff4f694 Started: 11/13/2023 10:14:50pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Stripe integration Can book a paid booking
Retry 1 • Initial Attempt |
0.35% (1)1 / 285 runfailed over last 7 days |
1.40% (4)4 / 285 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests user Different Locations Tests Can add Organzer Phone Number location and book with it
Retry 1 • Initial Attempt |
0.68% (2)2 / 292 runsfailed over last 7 days |
4.45% (13)13 / 292 runsflaked over last 7 days |
|
Event Types tests user Different Locations Tests Can add Link Meeting as location and book with it
Retry 1 • Initial Attempt |
0.69% (2)2 / 290 runsfailed over last 7 days |
6.90% (20)20 / 290 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
1.33% (4)4 / 300 runsfailed over last 7 days |
54.33% (163)163 / 300 runsflaked over last 7 days |
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
16.67% (50)50 / 300 runsfailed over last 7 days |
77.67% (233)233 / 300 runsflaked over last 7 days |
📄 apps/web/playwright/webhook.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
FORM_SUBMITTED on submitting team form, triggers team webhook
Retry 1 • Initial Attempt |
1.04% (3)3 / 289 runsfailed over last 7 days |
12.80% (37)37 / 289 runsflaked over last 7 days |
📄 apps/web/playwright/managed-event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Managed Event Types tests Can create managed event type
Retry 1 • Initial Attempt |
9.69% (28)28 / 289 runsfailed over last 7 days |
20.07% (58)58 / 289 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 1 • Initial Attempt |
0.68% (2)2 / 293 runsfailed over last 7 days |
38.23% (112)112 / 293 runsflaked over last 7 days |
📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Router URL should work
Retry 1 • Initial Attempt |
0.35% (1)1 / 288 runfailed over last 7 days |
13.89% (40)40 / 288 runsflaked over last 7 days |
📄 apps/web/playwright/reschedule.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Reschedule Tests Should display request reschedule send on bookings/cancelled
Retry 1 • Initial Attempt |
0.67% (2)2 / 298 runsfailed over last 7 days |
0.34% (1)1 / 298 runflaked over last 7 days |
CarinaWolli
commented
Nov 9, 2023
hariombalhara
requested changes
Nov 13, 2023
Member
There was a problem hiding this comment.
The approach looks correct to me now @CarinaWolli. Left a few comments to make the code more DRY and comfortable to understand.
Also, I think it could make sense to unit test it as it seems like an important endpoint to me(Could be a followup)
Member
Author
|
@hariombalhara Thank you for the feedback. I made the adjustments to the code, can you take a look again? Also, I will follow up with some tests: #12355 |
zomars
pushed a commit
that referenced
this pull request
Jan 29, 2024
Co-authored-by: CarinaWolli <wollencarina@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes
unhandled promise rejectionerror that was caused by await before Promise.allSettled.Now we first load all needed workflowReminders and after that we loop over all workflowReminders and create the promises.
fixes #12340
Type of change