feat: AtomsProvider component#12354
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes! |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 315 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 11/14/2023 02:50:33pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: a4e882c Started: 11/14/2023 02:42:01pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 1 • Initial Attempt |
0.36% (1)1 / 281 runfailed over last 7 days |
31.67% (89)89 / 281 runsflaked over last 7 days |
📄 apps/web/playwright/teams.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Teams - NonOrg Can create a private team
Retry 1 • Initial Attempt |
0% (0)0 / 288 runsfailed over last 7 days |
23.61% (68)68 / 288 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
1.02% (3)3 / 295 runsfailed over last 7 days |
53.90% (159)159 / 295 runsflaked over last 7 days |
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
15.31% (45)45 / 294 runsfailed over last 7 days |
80.61% (237)237 / 294 runsflaked over last 7 days |
There was a problem hiding this comment.
Looks good, but I would remove comments
// context for the api key value and // custom hook to simplify using the context because they restate what the code already does. You should only use comments if it's not possible to understand what is going on based on code itself, and even then before adding comments need to think if you can re-factor code without making comments.
* init: atoms provider component * chore: add atoms provider to index of atoms package * cleanup comments
3 participants
What does this PR do?
Adds an
AtomsProvidercomponent which acts as a context provider for all other component wrapped around it (PostHog does something similar here)