Skip to content

feat: add a button to embed profile#12630

Closed
harshithpabbati wants to merge 1 commit intocalcom:mainfrom
harshithpabbati:embed-profile-button
Closed

feat: add a button to embed profile#12630
harshithpabbati wants to merge 1 commit intocalcom:mainfrom
harshithpabbati:embed-profile-button

Conversation

@harshithpabbati
Copy link
Copy Markdown
Contributor

@harshithpabbati harshithpabbati commented Dec 2, 2023 •
edited
Loading

What does this PR do?

This PR is to add an Embed button for profiles.

Fixes #11713

https://www.loom.com/share/48aaff8105de4ed0926de8ad5290fac2?sid=90afc271-2093-4fb0-88d8-15df13fc9ab8

Requirement/Documentation

  • If there is a requirement document, please, share it here.
  • If there is ab UI/UX design document, please, share it here.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 2, 2023

Someone is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Dec 2, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 2, 2023 •
edited
Loading

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

@harshithpabbati harshithpabbati changed the title add a button to embed profile feat: add a button to embed profile Dec 2, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 2, 2023 •
edited
Loading

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@Udit-takkar Udit-takkar self-requested a review December 2, 2023 18:47
@zomars zomars added the osshack Submission for 2023 OSShack label Dec 2, 2023
emrysal
emrysal requested changes Dec 3, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like that the email embed is blank for some reason, possibly due to absence of some components?

@harshithpabbati
Copy link
Copy Markdown
Contributor Author

harshithpabbati commented Dec 3, 2023

It looks like that the email embed is blank for some reason, possibly due to absence of some components?

@emrysal email embed depends upon the event type, but here since we want to embed the user profile, should I hide the "email embed" option for users/team embed? 🤔

@harshithpabbati
Copy link
Copy Markdown
Contributor Author

harshithpabbati commented Dec 3, 2023

@emrysal just made the change, it's gonna hide the email embed for user/team profiles.
Screenshot 2023-12-03 at 10 03 17 PM

@emrysal
Copy link
Copy Markdown
Contributor

emrysal commented Dec 3, 2023

Thank you! I'll accept your entry to OSS Hack 🙏 ; will leave the decision to approve the PR itself to @ciaranha.

@emrysal emrysal requested a review from ciaranha December 3, 2023 17:30
@PeerRich PeerRich added 🚨 needs approval This feature request has not been reviewed yet by the Product Team and needs approval beforehand Low priority Created by Linear-GitHub Sync labels Dec 4, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 19, 2023

This PR is being marked as stale due to inactivity.

@github-actions github-actions Bot added the Stale label Dec 19, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 27, 2023

This PR is being closed due to inactivity. Please reopen if work is intended to be continued.

@github-actions github-actions Bot closed this Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Udit-takkar Udit-takkar Awaiting requested review from Udit-takkar

@emrysal emrysal Awaiting requested review from emrysal

@ciaranha ciaranha Awaiting requested review from ciaranha

Assignees

@ciaranha ciaranha

Labels

Low priority Created by Linear-GitHub Sync 🚨 needs approval This feature request has not been reviewed yet by the Product Team and needs approval beforehand osshack Submission for 2023 OSShack Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

New profile embed button

6 participants

@harshithpabbati @CLAassistant @emrysal @zomars @ciaranha @PeerRich