Skip to content

[WIP] Feat calendar sync#12665

Closed
alannnc wants to merge 4 commits intocalcom:mainfrom
alannnc:feat-calendar-sync
Closed

[WIP] Feat calendar sync#12665
alannnc wants to merge 4 commits intocalcom:mainfrom
alannnc:feat-calendar-sync

Conversation

@alannnc
Copy link
Copy Markdown
Contributor

@alannnc alannnc commented Dec 3, 2023

What does this PR do?

Fixes # (issue)

Requirement/Documentation

  • If there is a requirement document, please, share it here.
  • If there is ab UI/UX design document, please, share it here.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 3, 2023

@alannnc is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 3, 2023

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "[WIP] Feat calendar sync". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@emrysal emrysal marked this pull request as draft December 3, 2023 22:08
@emrysal
Copy link
Copy Markdown
Contributor

emrysal commented Dec 4, 2023

@alannnc FYI there's no changed files in this draft - missed a commit?

@alannnc
Copy link
Copy Markdown
Contributor Author

alannnc commented Dec 4, 2023

@alannnc FYI there's no changed files in this draft - missed a commit?

@emrysal Needed the url for the submission only but didn't make it to have it fully working, let's keep it in draft while I cook it now. 👍

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 4, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

New Page Added

The following page was added to the bundle from the code in this PR:

Page Size (compressed) First Load % of Budget (350 KB)
/calendar-sync 451.57 KB 615.18 KB 175.77%

Thirteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/apps/[slug]/[...pages] 542.79 KB 706.41 KB 201.83% (🟢 -0.31%)
/org/[orgSlug] 226.88 KB 390.5 KB 111.57% (🟢 -0.38%)
/org/[orgSlug]/[user] 233.43 KB 397.04 KB 113.44% (🟢 -0.38%)
/org/[orgSlug]/[user]/embed 233.45 KB 397.06 KB 113.45% (🟢 -0.39%)
/org/[orgSlug]/embed 226.9 KB 390.51 KB 111.58% (🟢 -0.39%)
/org/[orgSlug]/team/[slug] 226.89 KB 390.51 KB 111.57% (🟢 -0.38%)
/settings/organizations/teams/other/[id]/profile 456.98 KB 620.6 KB 177.31% (🟢 -0.37%)
/settings/security/sso 260.84 KB 424.45 KB 121.27% (🟢 -0.31%)
/settings/teams/[id]/profile 457.8 KB 621.42 KB 177.55% (🟢 -0.38%)
/settings/teams/[id]/sso 261.36 KB 424.97 KB 121.42% (🟢 -0.31%)
/team/[slug] 226.85 KB 390.46 KB 111.56% (🟢 -0.38%)
/team/[slug]/embed 226.89 KB 390.5 KB 111.57% (🟢 -0.38%)
/video/[uid] 244.52 KB 408.13 KB 116.61% (🟢 -0.38%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@CarinaWolli CarinaWolli added the osshack Submission for 2023 OSShack label Dec 4, 2023
@PeerRich PeerRich added the 🚨 needs approval This feature request has not been reviewed yet by the Product Team and needs approval beforehand label Dec 4, 2023
@github-actions
Copy link
Copy Markdown
Contributor

This PR is being marked as stale due to inactivity.

@github-actions github-actions Bot added the Stale label Dec 19, 2023
@alannnc alannnc closed this Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🚨 needs approval This feature request has not been reviewed yet by the Product Team and needs approval beforehand osshack Submission for 2023 OSShack Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants