refactor: Refactor seats logic#12905
Merged
Merged
Conversation
Current Playwright Test Results Summary✅ 80 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 01/15/2024 10:00:44pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 17ca289 Started: 01/15/2024 09:55:13pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Long Text Question and Each Other Question Long Text required and Number not required
Retry 1 • Initial Attempt |
0.25% (1)1 / 394 runfailed over last 7 days |
2.28% (9)9 / 394 runsflaked over last 7 days |
📄 apps/web/playwright/booking/addressQuestione2e/addressQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Address Question and Each Other Question Booking With Address Question and Short text question Address required and Short text required
Retry 1 • Initial Attempt |
0.50% (2)2 / 403 runsfailed over last 7 days |
3.72% (15)15 / 403 runsflaked over last 7 days |
CarinaWolli
requested changes
Jan 15, 2024
Member
There was a problem hiding this comment.
After type errors are fixed, I can approve 👍
EDIT: There are failing unit and e2e tests as well which might be related to the changes (https://github.com/calcom/cal.com/pull/12905/files#r1443076439)
* chore: add error message for no default user availability * chore: check only availability * chore: change message * chore: add eventType
CarinaWolli
approved these changes
Jan 15, 2024
Member
CarinaWolli
left a comment
CarinaWolli
left a comment
There was a problem hiding this comment.
Great work @joeauyeung 👏🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #12062
What does this PR do?
handleSeatslogic into separate files and into a new folder structureRequirement/Documentation
Type of change
How should this be tested?
Mandatory Tasks
Checklist