Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
Contributor
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Udit-takkar
commented
Jan 5, 2024
| ); | ||
| } | ||
|
|
||
| const DisplayLocation = ({ |
Contributor
Author
There was a problem hiding this comment.
Just created a common component
Udit-takkar
commented
Jan 5, 2024
Comment on lines
+337
to
+338
| const latestVideoReference = videoReferences[videoReferences.length - 1]; | ||
|
|
Contributor
Author
There was a problem hiding this comment.
use the latest video reference instead of the first one
Contributor
|
Thank you for fixing this, I ran into this issue a few times and it got super annoying |
PeerRich
approved these changes
Jan 7, 2024
Member
|
can we have E2E tests for this? |
This was referenced Jan 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #12971
Fixes #13060
To reproduce the bug
you would get the error "room does not exist or not found" because the room has been deleted when you rescheduled.
Type of change