Skip to content

feat(app-store): add feishu calendar#13089

Merged
PeerRich merged 3 commits intocalcom:mainfrom
tklk-forks:feishucal
Jan 8, 2024
Merged

feat(app-store): add feishu calendar#13089
PeerRich merged 3 commits intocalcom:mainfrom
tklk-forks:feishucal

Conversation

@techknowlogick
Copy link
Copy Markdown
Contributor

@techknowlogick techknowlogick commented Jan 8, 2024

What does this PR do?

Cal.com supports Lark, the international version of Feishu. However, depending on where your tenant is, you cannot use the Lark connection.

This PR adds an app for users who are in the Feishu tenant.

Fixes #12953

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Tests (Unit/Integration/E2E or any other test)
  • This change requires a documentation update

How should this be tested?

  • Create an org on feishu.cn with an example user that has a calendar
  • Create a new app at https://open.feishu.cn/ and get the app ID and secret to be used, and connect that in your dev environment
  • Install app and test that it pulls in the calendar
  • Confirm that events can't be booked at the same time as something already scheduled in the linked feishu calendar

(I can provide test keys/whatnot via PM if you don't wish to create an account yourself)

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 8, 2024

@techknowlogick is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jan 8, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 8, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@github-actions github-actions Bot added calendar-apps area: calendar, google calendar, outlook, lark, microsoft 365, apple calendar Low priority Created by Linear-GitHub Sync ✨ feature New feature or request labels Jan 8, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 8, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@sean-brydon sean-brydon requested a review from joeauyeung January 8, 2024 08:23
Copy link
Copy Markdown
Member

@PeerRich PeerRich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a copy of lark code right? should be fine then

can you uncommit your yarn.lock file? 🙏

@PeerRich PeerRich merged commit a40520b into calcom:main Jan 8, 2024
PeerRich added a commit that referenced this pull request Jan 8, 2024
PeerRich added a commit that referenced this pull request Jan 8, 2024
@PeerRich
Copy link
Copy Markdown
Member

PeerRich commented Jan 8, 2024

@techknowlogick i made a mistake, can you reopen the PR please? 🙏

@techknowlogick techknowlogick deleted the feishucal branch January 8, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

calendar-apps area: calendar, google calendar, outlook, lark, microsoft 365, apple calendar ✨ feature New feature or request Low priority Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feishu Cal connect

3 participants