fix: use DateRangePicker component in my-account/out-of-office by CarinaWolli · Pull Request #13207 · calcom/cal.diy

CarinaWolli · 2024-01-12T20:04:32Z

What does this PR do?

Use DateRangePicker component in /settings/my-account/out-of-office instead of custom DatePicker.
Also, adds some design improvements.

After:

Before:

After:

Before:

github-actions · 2024-01-12T20:04:44Z

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

vercel · 2024-01-12T20:04:46Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
ai	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 12, 2024 10:03pm
api	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 12, 2024 10:03pm
cal-demo	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Jan 12, 2024 10:03pm
dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 12, 2024 10:03pm
qa	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Jan 12, 2024 10:03pm

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
cal	⬜️ Ignored (Inspect)	Visit Preview		Jan 12, 2024 10:03pm
ui	⬜️ Ignored (Inspect)	Visit Preview		Jan 12, 2024 10:03pm

CarinaWolli · 2024-01-12T20:07:37Z

+                control={control}
+                defaultValue={dateRange}
+                render={() => (
+                  <DateRangePicker


Use DateRangePicker from @calcom/ui here

deploysentinel · 2024-01-12T20:16:46Z

Current Playwright Test Results Summary

✅ 370 Passing - ⚠️ 23 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 01/14/2024 01:56:36pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 8ef4917

Started: 01/14/2024 01:49:54pm UTC

⚠️ Flakes

📄 apps/web/playwright/locale.e2e.ts • 13 Flakes

Top 1 Common Error Messages

`null`	13 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
unauthorized user sees correct translations (de) should use correct translations and html attributes Retry 1 • Initial Attempt	-9.90% (-19) -19 / 192 runs failed over last 7 days	9.90% (19) 19 / 192 runs flaked over last 7 days
unauthorized user sees correct translations (ar) should use correct translations and html attributes Retry 1 • Initial Attempt	-9.90% (-19) -19 / 192 runs failed over last 7 days	9.90% (19) 19 / 192 runs flaked over last 7 days
unauthorized user sees correct translations (zh) should use correct translations and html attributes Retry 1 • Initial Attempt	-9.90% (-19) -19 / 192 runs failed over last 7 days	9.90% (19) 19 / 192 runs flaked over last 7 days
unauthorized user sees correct translations (zh-CN) should use correct translations and html attributes Retry 1 • Initial Attempt	-9.90% (-19) -19 / 192 runs failed over last 7 days	9.90% (19) 19 / 192 runs flaked over last 7 days
unauthorized user sees correct translations (zh-TW) should use correct translations and html attributes Retry 1 • Initial Attempt	-9.90% (-19) -19 / 192 runs failed over last 7 days	9.90% (19) 19 / 192 runs flaked over last 7 days
unauthorized user sees correct translations (pt) should use correct translations and html attributes Retry 1 • Initial Attempt	-9.90% (-19) -19 / 192 runs failed over last 7 days	9.90% (19) 19 / 192 runs flaked over last 7 days
unauthorized user sees correct translations (pt-br) should use correct translations and html attributes Retry 1 • Initial Attempt	-9.90% (-19) -19 / 192 runs failed over last 7 days	9.90% (19) 19 / 192 runs flaked over last 7 days
unauthorized user sees correct translations (es-419) should use correct translations and html attributes Retry 1 • Initial Attempt	-9.90% (-19) -19 / 192 runs failed over last 7 days	9.90% (19) 19 / 192 runs flaked over last 7 days
authorized user sees correct translations (de) should return correct translations and html attributes Retry 1 • Initial Attempt	-9.90% (-19) -19 / 192 runs failed over last 7 days	9.90% (19) 19 / 192 runs flaked over last 7 days
authorized user sees correct translations (pt-br) should return correct translations and html attributes Retry 1 • Initial Attempt	-9.90% (-19) -19 / 192 runs failed over last 7 days	9.90% (19) 19 / 192 runs flaked over last 7 days
authorized user sees correct translations (ar) should return correct translations and html attributes Retry 1 • Initial Attempt	-9.90% (-19) -19 / 192 runs failed over last 7 days	9.90% (19) 19 / 192 runs flaked over last 7 days
authorized user sees changed translations (de->ar) should return correct translations and html attributes Retry 1 • Initial Attempt	-2.11% (-4) -4 / 190 runs failed over last 7 days	9.47% (18) 18 / 190 runs flaked over last 7 days
authorized user sees changed translations (de->pt-BR) [locale1] should return correct translations and html attributes Retry 1 • Initial Attempt	-7.95% (-14) -14 / 176 runs failed over last 7 days	10.23% (18) 18 / 176 runs flaked over last 7 days

📄 apps/web/playwright/login.2fa.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
2FA Tests should allow a user to enable 2FA and login using 2FA Retry 1 • Initial Attempt	0% (0) 0 / 192 runs failed over last 7 days	34.90% (67) 67 / 192 runs flaked over last 7 days

📄 apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Stripe integration When event is paid and confirmed Cancelled paid booking should be refunded Retry 1 • Initial Attempt	35.71% (110) 110 / 308 runs failed over last 7 days	2.60% (8) 8 / 308 runs flaked over last 7 days

📄 apps/web/playwright/event-types.e2e.ts • 2 Flakes

Top 1 Common Error Messages

`null`	2 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Event Types tests user -- future Different Locations Tests Can add Cal video location and book with it Retry 1 • Initial Attempt	1.49% (5) 5 / 336 runs failed over last 7 days	2.08% (7) 7 / 336 runs flaked over last 7 days
Event Types tests user -- future Different Locations Tests Can remove location from multiple locations that are saved Retry 2 • Retry 1 • Initial Attempt	0.30% (1) 1 / 331 run failed over last 7 days	3.63% (12) 12 / 331 runs flaked over last 7 days

📄 apps/web/playwright/booking/radioGroupQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Booking With Radio Question and Each Other Question Booking With Radio Question and Address Question Booking With Radio Question and checkbox Question Radio and checkbox not required Retry 1 • Initial Attempt	0.31% (1) 1 / 319 run failed over last 7 days	1.57% (5) 5 / 319 runs flaked over last 7 days

📄 apps/web/playwright/payment-apps.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Payment app Should only be allowed to enable one payment app Retry 1 • Initial Attempt	0% (0) 0 / 315 runs failed over last 7 days	0.63% (2) 2 / 315 runs flaked over last 7 days

📄 packages/embeds/embed-core/playwright/tests/preview.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Preview Preview - embed-core should load Retry 1 • Initial Attempt	0% (0) 0 / 340 runs failed over last 7 days	19.12% (65) 65 / 340 runs flaked over last 7 days

📄 apps/web/playwright/booking/addressQuestione2e/addressQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Booking With Address Question and Each Other Question Booking With Address Question and Long text Question Addres required and Long Text required Retry 1 • Initial Attempt	0.31% (1) 1 / 325 run failed over last 7 days	4% (13) 13 / 325 runs flaked over last 7 days

📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes

Top 1 Common Error Messages

`null`	2 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Popup Tests should be able to reschedule Retry 1 • Initial Attempt	12.65% (43) 43 / 340 runs failed over last 7 days	84.71% (288) 288 / 340 runs flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API Retry 1 • Initial Attempt	4.13% (14) 14 / 339 runs failed over last 7 days	77.58% (263) 263 / 339 runs flaked over last 7 days

View Detailed Build Results

* refactor: booker component * refactor: booker component * refactor: useBookings, useOverlayCalendar * fix: imports and types * fix: don't allow uid update in bookings update api (#13071) * don't allow uid update in bookings update api * omit uid from schemaBookingEditBodyParams instead of updating schemaBookingBaseBodyParams --------- Co-authored-by: Alex van Andel <me@alexvanandel.com> Co-authored-by: Peer Richelsen <peeroke@gmail.com> * New Crowdin translations by Github Action * fix: use DateRangePicker component in my-account/out-of-office (#13207) * fix: remove duplicate useBrandColors * fix: add missing localstorage package * fix: booking form initial values * fix: redirect to payment form * refactor: handle fetching schedule only in Booker * fixup! refactor: handle fetching schedule only in Booker * fix: remove empty file * useBookerLayout.ts useEffect dependencies isMobile and isEmbed were missing and validateLayout was redundant * useInitialFormValues useEffect dependencies * fix: remove unused hook * refactor: split logic from data fetch overlayCalendar * fix: small changes * fix: inifinite loop * fix: toggle calendar --------- Co-authored-by: Rajiv Sahal <sahalrajiv-extc@atharvacoe.ac.in> Co-authored-by: Riddhesh Mahajan <40472653+riddhesh-mahajan@users.noreply.github.com> Co-authored-by: Alex van Andel <me@alexvanandel.com> Co-authored-by: Peer Richelsen <peeroke@gmail.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: Carina Wollendorfer <30310907+CarinaWolli@users.noreply.github.com> Co-authored-by: Lauris Skraucis <lauris.skraucis@gmail.com>

CarinaWolli added 3 commits January 12, 2024 14:07

use DateRangePicker component

f1166ae

improve design

2a917e8

fix hidden dateRangePicker behind TableHeader

63e06cf

keithwillcode added the core area: core, team members only label Jan 12, 2024

CarinaWolli changed the title ~~use DateRangePicker component~~ fix: use DateRangePicker component in my-account/out-of-office Jan 12, 2024

CarinaWolli commented Jan 12, 2024

View reviewed changes

CarinaWolli marked this pull request as ready for review January 12, 2024 20:08

PeerRich approved these changes Jan 12, 2024

View reviewed changes

PeerRich enabled auto-merge (squash) January 12, 2024 21:07

Merge branch 'main' into fix/use-DatePicker-component

8ef4917

vercel bot deployed to Preview – ai January 12, 2024 21:55 View deployment

vercel bot deployed to Preview – api January 12, 2024 21:57 View deployment

vercel bot deployed to Preview – dev January 12, 2024 22:03 View deployment

PeerRich merged commit 67c318e into main Jan 14, 2024

PeerRich deleted the fix/use-DatePicker-component branch January 14, 2024 13:58

ThyMinimalDev pushed a commit that referenced this pull request Jan 15, 2024

fix: use DateRangePicker component in my-account/out-of-office (#13207)

1d9cf2d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: use DateRangePicker component in my-account/out-of-office#13207

fix: use DateRangePicker component in my-account/out-of-office#13207
PeerRich merged 4 commits intomainfrom
fix/use-DatePicker-component

CarinaWolli commented Jan 12, 2024

Uh oh!

github-actions bot commented Jan 12, 2024 •

edited

Loading

Uh oh!

vercel bot commented Jan 12, 2024 •

edited

Loading

Uh oh!

CarinaWolli Jan 12, 2024

Uh oh!

deploysentinel bot commented Jan 12, 2024 •

edited

Loading

Top 1 Common Error Messages

Test Case Results

Test Case Results

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Top 1 Common Error Messages

Test Case Results

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

CarinaWolli commented Jan 12, 2024

What does this PR do?

Uh oh!

github-actions bot commented Jan 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Jan 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CarinaWolli Jan 12, 2024

Choose a reason for hiding this comment

Uh oh!

deploysentinel bot commented Jan 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current Playwright Test Results Summary

⚠️ Flakes

Top 1 Common Error Messages

Test Case Results

Test Case Results

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Top 1 Common Error Messages

Test Case Results

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Jan 12, 2024 •

edited

Loading

vercel bot commented Jan 12, 2024 •

edited

Loading

deploysentinel bot commented Jan 12, 2024 •

edited

Loading