chore: add error message for no availability by Udit-takkar · Pull Request #13230 · calcom/cal.diy

Udit-takkar · 2024-01-15T11:33:22Z

What does this PR do?

Fixes https://calcom.sentry.io/issues/4868439930/?alert_rule_id=12606822&alert_timestamp=1705309959810&alert_type=email&environment=vercel-production&notification_uuid=c6acef7e-7f8b-41cd-a529-b2a3984c8b6c&project=4504055091625984&referrer=alert_email

https://threads.com/messages/36061128-87fb-48a0-b9c1-fd67f9507c06?messageID=b02436ed-33f0-4df6-9033-201c44e3b835

Requirement/Documentation

If there is a requirement document, please, share it here.
If there is ab UI/UX design document, please, share it here.

Type of change

Bug fix (non-breaking change which fixes an issue)
Chore (refactoring code, technical debt, workflow improvements)

vercel · 2024-01-15T11:33:32Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
api	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 15, 2024 5:09pm
cal-demo	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Jan 15, 2024 5:09pm
dev	❌ Failed (Inspect)			Jan 15, 2024 5:09pm
ui	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Jan 15, 2024 5:09pm

3 Ignored Deployments

Name	Status	Preview	Updated (UTC)
ai	⬜️ Ignored (Inspect)	Visit Preview	Jan 15, 2024 5:09pm
cal	⬜️ Ignored (Inspect)	Visit Preview	Jan 15, 2024 5:09pm
qa	⬜️ Ignored (Inspect)	Visit Preview	Jan 15, 2024 5:09pm

github-actions · 2024-01-15T11:33:35Z

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

deploysentinel · 2024-01-15T11:47:21Z

Current Playwright Test Results Summary

✅ 382 Passing - ⚠️ 11 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 01/15/2024 05:26:35pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: c2c816a

Started: 01/15/2024 05:14:35pm UTC

⚠️ Flakes

📄 apps/web/playwright/booking/longTextQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Booking With Long Text Question and Each Other Question Booking With Long Text Question and Number Question Long Text and Number required Retry 1 • Initial Attempt	0.26% (1) 1 / 379 run failed over last 7 days	3.17% (12) 12 / 379 runs flaked over last 7 days

📄 apps/web/playwright/login.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Login and logout tests Login flow validations Should warn when user does not exist Retry 1 • Initial Attempt	0% (0) 0 / 254 runs failed over last 7 days	3.15% (8) 8 / 254 runs flaked over last 7 days

📄 apps/web/playwright/booking/allQuestions.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Booking With All Questions Selecting and filling all questions as optional Retry 1 • Initial Attempt	0.26% (1) 1 / 381 run failed over last 7 days	3.94% (15) 15 / 381 runs flaked over last 7 days

📄 apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Stripe integration Can book a paid booking Retry 2 • Retry 1 • Initial Attempt	29.43% (113) 113 / 384 runs failed over last 7 days	6.25% (24) 24 / 384 runs flaked over last 7 days

📄 apps/web/playwright/booking/addressQuestione2e/addressQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Booking With Address Question and Each Other Question Booking With Address Question and select Question Address required and select required Retry 1 • Initial Attempt	0.52% (2) 2 / 385 runs failed over last 7 days	2.08% (8) 8 / 385 runs flaked over last 7 days

📄 apps/web/playwright/auth/delete-account.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Can delete user account Retry 1 • Initial Attempt	0.24% (1) 1 / 409 run failed over last 7 days	0.24% (1) 1 / 409 run flaked over last 7 days

📄 apps/web/playwright/booking/multipleEmailQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Booking With Multiple Email Question and Each Other Question Booking With Multiple Email Question and checkbox Question Multiple Email and checkbox not required Retry 1 • Initial Attempt	0% (0) 0 / 384 runs failed over last 7 days	3.39% (13) 13 / 384 runs flaked over last 7 days

📄 apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Event Types tests user -- future enabling recurring event comes with default options Retry 1 • Initial Attempt	0.73% (3) 3 / 411 runs failed over last 7 days	9% (37) 37 / 411 runs flaked over last 7 days

📄 apps/web/playwright/organization/organization-invitation.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Organization Email not matching orgAutoAcceptEmail Org Invitation Retry 1 • Initial Attempt	2.23% (9) 9 / 404 runs failed over last 7 days	13.12% (53) 53 / 404 runs flaked over last 7 days

📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes

Top 1 Common Error Messages

`null`	2 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Popup Tests should be able to reschedule Retry 1 • Initial Attempt	12.62% (51) 51 / 404 runs failed over last 7 days	83.42% (337) 337 / 404 runs flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API Retry 1 • Initial Attempt	2.73% (11) 11 / 403 runs failed over last 7 days	77.17% (311) 311 / 403 runs flaked over last 7 days

View Detailed Build Results

Udit-takkar · 2024-01-15T12:11:09Z

+  if (!schedule.availability) {
+    throw new HttpError({ statusCode: 400, message: ErrorCode.AvailabilityNotFoundInSchedule });
+  }
+


Added a check here

* chore: add error message for no default user availability * chore: check only availability * chore: change message * chore: add eventType

Get switcher working Add organization seeder wip Remove dead code Fix unit tests relevantProfile -> profile cache bust One more comment Squash migrations Copy to profile table Update schema Fix existing user invite flow Add profile table Copy to profile table Update schema chore: small improvements to signup (#13227) * removed features on mobile, better background color * nit * dark mode nits New Crowdin translations by Github Action fix: event reschedule workflow trigger (#13122) * fix event reschedule workflow trigger * uncomment previously failed test * review fix --------- Co-authored-by: Joe Au-Yeung <65426560+joeauyeung@users.noreply.github.com> Co-authored-by: CarinaWolli <wollencarina@gmail.com> chore: added community support to help (#13213) refactor: Abstract `handleSeats` from `handleNewBooking` (#12062) * Refactor createBooking * Type fix * Abstract handleSeats * Create Invitee type * Create OrganizerUser type * Abstract addVideoCallDataToEvt * Abstract createLoggerWithEventDetails * Abstract `handleAppStatus` from handler * Create ReqAppsStatus type * Move `deleteMeeting` and `getCalendar` * Set parameters for `handleSeats` * Typescript refactor * Change function params from req * Type fix --------- Co-authored-by: Morgan <33722304+ThyMinimalDev@users.noreply.github.com> Co-authored-by: Erik <erik@erosemberg.com> fix: Dynamic group booking org-migration redirect (#13223) * fix: Dynamic group booking redirect * Fix flaky private team test test: Check availability tab and all your functions (teste2e-availability) (#12434) * add changes * add changes * add changes * add changes * Requested changes * Change way to grab element --------- Co-authored-by: gitstart-calcom <gitstart-calcom@users.noreply.github.com> Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> Co-authored-by: Morgan <33722304+ThyMinimalDev@users.noreply.github.com> Co-authored-by: Keith Williams <keithwillcode@gmail.com> Co-authored-by: Joe Au-Yeung <65426560+joeauyeung@users.noreply.github.com> fix: Reschedule a cancelled booking (#13170) * fix: Reschedule a cancelled booking * canceled instead of cancelled --------- Co-authored-by: Joe Au-Yeung <65426560+joeauyeung@users.noreply.github.com> Co-authored-by: Carina Wollendorfer <30310907+CarinaWolli@users.noreply.github.com> v3.7.0 test: In Team Event type when location is Organizer Default App and U… (#12939) * test: In Team Event type when location is Organizer Default App and User Metadata is emoty * chore: use variable * fix: type error test: add test for invalid cal video (#13103) * test: add test for invalid cal video * chore: add confirm * chore: fix type error * chore: update code * test: add unit test * chore: type error * chore * chore: type * chore: fix test * chore --------- Co-authored-by: Carina Wollendorfer <30310907+CarinaWolli@users.noreply.github.com> chore: add error message for no availability (#13230) * chore: add error message for no default user availability * chore: check only availability * chore: change message * chore: add eventType fix: Team revert with members (#13228) refactor: Refactor seats logic (#12905) * Refactor createBooking * Type fix * Abstract handleSeats * Create Invitee type * Create OrganizerUser type * Abstract addVideoCallDataToEvt * Abstract createLoggerWithEventDetails * Abstract `handleAppStatus` from handler * Create ReqAppsStatus type * Move `deleteMeeting` and `getCalendar` * Set parameters for `handleSeats` * Typescript refactor * Change function params from req * Type fix * Move handleSeats * Abstract lastAttendeeDeleteBooking * Create function for rescheduling seated events * Fix imports on reschedule seats function * Fix imports * Import handleSeats function * Fix rescheduleUid type * Refactor owner reschedule to new time slot * Refactor combine two booking times together * Reschedule as an attendee * Refactor createNewSeat * Remove old handleSeats * Remove lastAttendeeDeleteBooking from handleNewBooking * Test for new attendee right params are passed * Unit test params for reschedule * Typo fix * Clean up * Create new seat test * Test when attendee already signs up for booking * Type fix * Test reschedule move attendee to existing booking * On reschedule create new booking * Test on last attendee cancel booking * Owner reschedule to new time slot * Owner rescheduling, merge two bookings together * Test: when merging more than available seats, then fail * Test: fail when event is full * Remove duplicate E2E tests * Clean up * Rename `addVideoCallDataToEvt` to `addVideoCallDataToEvent` * Refactor `calcAppsStatus` * Assign `evt` to resutl of `addVideoCallDataToEvent` * Use prisma.transaction when moving attendees * Clean create seat call * Use ErrorCode enum * Use attendeeRescheduledSeatedBooking function * Await function * Prevent double triggering of workflows * Use inviteeToAdd in createNewSeat * Remove unused error code * Remove old handleSeats file * Type fix * Type fix * Type fix * Type fix * Type fix * Type fix * Type fix * Type fix --------- Co-authored-by: Morgan <33722304+ThyMinimalDev@users.noreply.github.com> Co-authored-by: Peer Richelsen <peeroke@gmail.com> Co-authored-by: Erik <erik@erosemberg.com> feat: Allow admins to filter bookings only by attendee emails (#13236) * chore: Allow admins to filter bookings only by attendee emails * Fix type error Fixed [CAL-2930] Org branding isnt centered in shell #13225 (#13237) Add profile table Copy to profile table Update schema Migrations Format

…ng users to an organization (#13002) * Add profile table Copy to profile table Update schema Migrations * wip * Get switcher working * Add organization seeder * wip * Remove dead code * Fix unit tests * relevantProfile -> profile * cache bust * One more comment * Squash migrations * Copy to profile table * Update schema * Fix existing user invite flow * Add profile table * Copy to profile table * Update schema * Format * Add profile table Copy to profile table Update schema Migrations * Format * wip Get switcher working Add organization seeder wip Remove dead code Fix unit tests relevantProfile -> profile cache bust One more comment Squash migrations Copy to profile table Update schema Fix existing user invite flow Add profile table Copy to profile table Update schema chore: small improvements to signup (#13227) * removed features on mobile, better background color * nit * dark mode nits New Crowdin translations by Github Action fix: event reschedule workflow trigger (#13122) * fix event reschedule workflow trigger * uncomment previously failed test * review fix --------- Co-authored-by: Joe Au-Yeung <65426560+joeauyeung@users.noreply.github.com> Co-authored-by: CarinaWolli <wollencarina@gmail.com> chore: added community support to help (#13213) refactor: Abstract `handleSeats` from `handleNewBooking` (#12062) * Refactor createBooking * Type fix * Abstract handleSeats * Create Invitee type * Create OrganizerUser type * Abstract addVideoCallDataToEvt * Abstract createLoggerWithEventDetails * Abstract `handleAppStatus` from handler * Create ReqAppsStatus type * Move `deleteMeeting` and `getCalendar` * Set parameters for `handleSeats` * Typescript refactor * Change function params from req * Type fix --------- Co-authored-by: Morgan <33722304+ThyMinimalDev@users.noreply.github.com> Co-authored-by: Erik <erik@erosemberg.com> fix: Dynamic group booking org-migration redirect (#13223) * fix: Dynamic group booking redirect * Fix flaky private team test test: Check availability tab and all your functions (teste2e-availability) (#12434) * add changes * add changes * add changes * add changes * Requested changes * Change way to grab element --------- Co-authored-by: gitstart-calcom <gitstart-calcom@users.noreply.github.com> Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> Co-authored-by: Morgan <33722304+ThyMinimalDev@users.noreply.github.com> Co-authored-by: Keith Williams <keithwillcode@gmail.com> Co-authored-by: Joe Au-Yeung <65426560+joeauyeung@users.noreply.github.com> fix: Reschedule a cancelled booking (#13170) * fix: Reschedule a cancelled booking * canceled instead of cancelled --------- Co-authored-by: Joe Au-Yeung <65426560+joeauyeung@users.noreply.github.com> Co-authored-by: Carina Wollendorfer <30310907+CarinaWolli@users.noreply.github.com> v3.7.0 test: In Team Event type when location is Organizer Default App and U… (#12939) * test: In Team Event type when location is Organizer Default App and User Metadata is emoty * chore: use variable * fix: type error test: add test for invalid cal video (#13103) * test: add test for invalid cal video * chore: add confirm * chore: fix type error * chore: update code * test: add unit test * chore: type error * chore * chore: type * chore: fix test * chore --------- Co-authored-by: Carina Wollendorfer <30310907+CarinaWolli@users.noreply.github.com> chore: add error message for no availability (#13230) * chore: add error message for no default user availability * chore: check only availability * chore: change message * chore: add eventType fix: Team revert with members (#13228) refactor: Refactor seats logic (#12905) * Refactor createBooking * Type fix * Abstract handleSeats * Create Invitee type * Create OrganizerUser type * Abstract addVideoCallDataToEvt * Abstract createLoggerWithEventDetails * Abstract `handleAppStatus` from handler * Create ReqAppsStatus type * Move `deleteMeeting` and `getCalendar` * Set parameters for `handleSeats` * Typescript refactor * Change function params from req * Type fix * Move handleSeats * Abstract lastAttendeeDeleteBooking * Create function for rescheduling seated events * Fix imports on reschedule seats function * Fix imports * Import handleSeats function * Fix rescheduleUid type * Refactor owner reschedule to new time slot * Refactor combine two booking times together * Reschedule as an attendee * Refactor createNewSeat * Remove old handleSeats * Remove lastAttendeeDeleteBooking from handleNewBooking * Test for new attendee right params are passed * Unit test params for reschedule * Typo fix * Clean up * Create new seat test * Test when attendee already signs up for booking * Type fix * Test reschedule move attendee to existing booking * On reschedule create new booking * Test on last attendee cancel booking * Owner reschedule to new time slot * Owner rescheduling, merge two bookings together * Test: when merging more than available seats, then fail * Test: fail when event is full * Remove duplicate E2E tests * Clean up * Rename `addVideoCallDataToEvt` to `addVideoCallDataToEvent` * Refactor `calcAppsStatus` * Assign `evt` to resutl of `addVideoCallDataToEvent` * Use prisma.transaction when moving attendees * Clean create seat call * Use ErrorCode enum * Use attendeeRescheduledSeatedBooking function * Await function * Prevent double triggering of workflows * Use inviteeToAdd in createNewSeat * Remove unused error code * Remove old handleSeats file * Type fix * Type fix * Type fix * Type fix * Type fix * Type fix * Type fix * Type fix --------- Co-authored-by: Morgan <33722304+ThyMinimalDev@users.noreply.github.com> Co-authored-by: Peer Richelsen <peeroke@gmail.com> Co-authored-by: Erik <erik@erosemberg.com> feat: Allow admins to filter bookings only by attendee emails (#13236) * chore: Allow admins to filter bookings only by attendee emails * Fix type error Fixed [CAL-2930] Org branding isnt centered in shell #13225 (#13237) Add profile table Copy to profile table Update schema Migrations Format * wip * Add profile relation everywhere * Fix schema * Fix invite handler * Add profileId during eventTypec reation * Get dashboard working with profile relatioon * Add workflow create repository * Add profileId to host * Add profileId to credential table * Add destinationCalendar repository * Add profileId to membership * Revert all profile related changes * Add acme and dunder * Fix membership profileId usgae * Various fixes * Some renaming * Fix failing tests * Debugging next-aut * Consolidate migrations * Testing fixes * Fix unit tests * Self review feedback * PR feedback * Fix orgMigration as well * Add profile schema and copy users to it * Remove migrations from here * Fix type issues * Fix type error after main merge * Remove movedFromUserId * Add missing migration file * Self review addressed * Joe's review addressed * Fix profile switcher --------- Co-authored-by: Joe Au-Yeung <65426560+joeauyeung@users.noreply.github.com>

chore: add error message for no default user availability

af8ace8

keithwillcode added the core area: core, team members only label Jan 15, 2024

Udit-takkar added this to the v3.7 milestone Jan 15, 2024

vercel Bot deployed to Preview – ai January 15, 2024 11:36 View deployment

vercel Bot deployed to Preview – api January 15, 2024 11:37 View deployment

vercel Bot deployed to Preview – dev January 15, 2024 11:43 View deployment

Udit-takkar added 2 commits January 15, 2024 17:39

chore: check only availability

4478d52

chore: change message

2322479

Udit-takkar commented Jan 15, 2024

View reviewed changes

vercel Bot deployed to Preview – api January 15, 2024 12:15 View deployment

Udit-takkar changed the title ~~chore: add error message for no default user availability~~ chore: add error message for no availability Jan 15, 2024

vercel Bot deployed to Preview – dev January 15, 2024 12:19 View deployment

PeerRich added Medium priority Created by Linear-GitHub Sync bookings area: bookings, availability, timezones, double booking labels Jan 15, 2024

chore: add eventType

6cf8e2f

vercel Bot deployed to Preview – api January 15, 2024 14:35 View deployment

vercel Bot deployed to Preview – dev January 15, 2024 14:38 View deployment

CarinaWolli previously approved these changes Jan 15, 2024

View reviewed changes

CarinaWolli enabled auto-merge (squash) January 15, 2024 16:25

Merge branch 'main' into chore/default-avail

b0473f6

vercel Bot deployed to Preview – api January 15, 2024 16:31 View deployment

vercel Bot deployed to Preview – dev January 15, 2024 16:34 View deployment

Merge branch 'main' into chore/default-avail

c2c816a

Udit-takkar dismissed CarinaWolli’s stale review via c2c816a January 15, 2024 17:03

keithwillcode added the consumer label Jan 15, 2024

vercel Bot had a problem deploying to Preview – dev January 15, 2024 17:08 Failure

vercel Bot deployed to Preview – api January 15, 2024 17:09 View deployment

keithwillcode modified the milestones: v3.7, v3.8 Jan 15, 2024

CarinaWolli approved these changes Jan 15, 2024

View reviewed changes

CarinaWolli merged commit 29b1f7b into main Jan 15, 2024

CarinaWolli deleted the chore/default-avail branch January 15, 2024 21:04

joeauyeung pushed a commit that referenced this pull request Jan 15, 2024

chore: add error message for no availability (#13230)

5d852ac

* chore: add error message for no default user availability * chore: check only availability * chore: change message * chore: add eventType

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: add error message for no availability#13230

chore: add error message for no availability#13230
CarinaWolli merged 6 commits into
mainfrom
chore/default-avail

Udit-takkar commented Jan 15, 2024 •

edited

Loading

Uh oh!

vercel Bot commented Jan 15, 2024 •

edited

Loading

Uh oh!

github-actions Bot commented Jan 15, 2024 •

edited

Loading

Uh oh!

deploysentinel Bot commented Jan 15, 2024 •

edited

Loading

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Top 1 Common Error Messages

Test Case Results

Uh oh!

Udit-takkar Jan 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Udit-takkar commented Jan 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Requirement/Documentation

Type of change

Uh oh!

vercel Bot commented Jan 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jan 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

deploysentinel Bot commented Jan 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current Playwright Test Results Summary

⚠️ Flakes

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Top 1 Common Error Messages

Test Case Results

Uh oh!

Udit-takkar Jan 15, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Udit-takkar commented Jan 15, 2024 •

edited

Loading

vercel Bot commented Jan 15, 2024 •

edited

Loading

github-actions Bot commented Jan 15, 2024 •

edited

Loading

deploysentinel Bot commented Jan 15, 2024 •

edited

Loading