refactor: app-store imports webhook.ts from @calcom/web#13257
Merged
Conversation
ThyMinimalDev
changed the title
Contributor
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
ThyMinimalDev
requested review from
exception,
hariombalhara and
keithwillcode
Contributor
Author
|
this file "cal.com/packages/app-store/paypal/api/index.ts" imports webhooks file from @calcom/web, but the file in @calcom/web just exports the same webhook file by importing it from app-store same thing with alby app |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
keithwillcode
approved these changes
Jan 16, 2024
PeerRich
approved these changes
Jan 16, 2024
zomars
approved these changes
Jan 16, 2024
Current Playwright Test Results Summary✅ 380 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 01/16/2024 03:09:09pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: e961f49 Started: 01/16/2024 02:59:12pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Reschedule for booking with seats If rescheduled/cancelled booking with seats it should display the correct number of seats
Retry 1 • Initial Attempt |
1.96% (7)7 / 357 runsfailed over last 7 days |
0.56% (2)2 / 357 runsflaked over last 7 days |
📄 apps/web/playwright/booking/longTextQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Long Text Question and Each Other Question Long Text required and Number not required
Retry 1 • Initial Attempt |
0.27% (1)1 / 367 runfailed over last 7 days |
2.18% (8)8 / 367 runsflaked over last 7 days |
📄 apps/web/playwright/login.2fa.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 2 • Retry 1 • Initial Attempt |
0% (0)0 / 272 runsfailed over last 7 days |
35.66% (97)97 / 272 runsflaked over last 7 days |
📄 apps/web/playwright/booking/selectQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Phone Question and Each Other Question Booking With Select Question and Address Question Select and Address not required
Retry 1 • Initial Attempt |
0.27% (1)1 / 365 runfailed over last 7 days |
1.64% (6)6 / 365 runsflaked over last 7 days |
📄 apps/web/playwright/booking/radioGroupQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Radio Question and Each Other Question Booking With Radio Question and Address Question Booking With Radio Question and Phone Question Radio and Phone not required
Retry 1 • Initial Attempt |
0.27% (1)1 / 367 runfailed over last 7 days |
1.91% (7)7 / 367 runsflaked over last 7 days |
📄 apps/web/playwright/booking/checkboxGroupQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and Radio group Question Checkbox Group and Radio group not required
Retry 1 • Initial Attempt |
0% (0)0 / 370 runsfailed over last 7 days |
1.08% (4)4 / 370 runsflaked over last 7 days |
📄 apps/web/playwright/booking/availability.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Check availability tab in a event-type Check availability in event type
Retry 1 • Initial Attempt |
26.19% (11)11 / 42 runsfailed over last 7 days |
30.95% (13)13 / 42 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests user -- legacy Different Locations Tests Can add Cal video location and book with it
Retry 1 • Initial Attempt |
0.26% (1)1 / 383 runfailed over last 7 days |
3.66% (14)14 / 383 runsflaked over last 7 days |
📄 apps/web/playwright/organization/organization-invitation.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Organization Email not matching orgAutoAcceptEmail Team invitation
Retry 1 • Initial Attempt |
5.60% (22)22 / 393 runsfailed over last 7 days |
27.23% (107)107 / 393 runsflaked over last 7 days |
📄 apps/web/playwright/booking/phoneQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Phone Question and Each Other Question Booking With Phone Question and Address Question Booking With Phone Question and checkbox group Question Phone and checkbox group required
Retry 1 • Initial Attempt |
1.31% (5)5 / 382 runsfailed over last 7 days |
2.36% (9)9 / 382 runsflaked over last 7 days |
📄 apps/web/playwright/oauth-provider.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
OAuth Provider should create valid access token & refresh token for team
Retry 1 • Initial Attempt |
0% (0)0 / 400 runsfailed over last 7 days |
18.50% (74)74 / 400 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 4 Flakes
Top 1 Common Error Messages
|
|
4 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 2 • Retry 1 • Initial Attempt |
13.42% (53)53 / 395 runsfailed over last 7 days |
82.03% (324)324 / 395 runsflaked over last 7 days |
|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
2.23% (9)9 / 404 runsfailed over last 7 days |
54.21% (219)219 / 404 runsflaked over last 7 days |
|
Popup Tests should open Routing Forms embed on click
Retry 1 • Initial Attempt |
-2.03% (-8)-8 / 394 runsfailed over last 7 days |
43.65% (172)172 / 394 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
2.79% (11)11 / 394 runsfailed over last 7 days |
76.65% (302)302 / 394 runsflaked over last 7 days |
📄 apps/web/playwright/availability.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Availablity tests Date Overrides
Retry 1 • Initial Attempt |
0.75% (3)3 / 402 runsfailed over last 7 days |
2.74% (11)11 / 402 runsflaked over last 7 days |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes app-store importing file from web for no reason
Type of change
Mandatory Tasks