Skip to content

test(core): add tests for events utils#13265

Merged
keithwillcode merged 2 commits into
calcom:mainfrom
43081j:core-tests
Jan 19, 2024
Merged

test(core): add tests for events utils#13265
keithwillcode merged 2 commits into
calcom:mainfrom
43081j:core-tests

Conversation

@43081j
Copy link
Copy Markdown
Contributor

@43081j 43081j commented Jan 16, 2024

This adds tests for the following utils found in core:

  • event utils
  • getAggregateWorkingHours
  • getCalendarsEvents

I was using the repo to give myself chance to try out a stack uncommon to me, so here's a few simple tests i wrote while i was understanding the sources.

Type of change

  • Tests (Unit/Integration/E2E or any other test)

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 16, 2024

@43081j is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jan 16, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 16, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@43081j 43081j changed the title test (core): add tests for events utils test(core): add tests for events utils Jan 16, 2024
This adds tests for the following utils found in `core`:

- event utils
- getAggregateWorkingHours
- getCalendarsEvents
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 16, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@keithwillcode keithwillcode self-assigned this Jan 17, 2024
@keithwillcode keithwillcode requested a review from a team January 17, 2024 11:07
@keithwillcode keithwillcode added the Low priority Created by Linear-GitHub Sync label Jan 17, 2024
@keithwillcode keithwillcode added this to the v3.8 milestone Jan 17, 2024
@keithwillcode keithwillcode added automated-tests area: unit tests, e2e tests, playwright community Created by Linear-GitHub Sync labels Jan 17, 2024
Copy link
Copy Markdown
Contributor

@keithwillcode keithwillcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work. Thanks so much for the contribution.

@keithwillcode keithwillcode enabled auto-merge (squash) January 19, 2024 13:13
@keithwillcode
Copy link
Copy Markdown
Contributor

keithwillcode commented Jan 19, 2024

/tip $20 @43081j

@algora-pbc
Copy link
Copy Markdown

algora-pbc Bot commented Jan 19, 2024

@43081j: You just got a $20 tip! 👉 Complete your Algora onboarding to collect your payment.

@calcom calcom deleted a comment from algora-pbc Bot Jan 19, 2024
@keithwillcode keithwillcode merged commit 26e50d2 into calcom:main Jan 19, 2024
@43081j 43081j deleted the core-tests branch January 19, 2024 14:51
@43081j
Copy link
Copy Markdown
Contributor Author

43081j commented Jan 19, 2024

no worries, thanks a lot for the review 👍 has been a fun repo to explore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated-tests area: unit tests, e2e tests, playwright community Created by Linear-GitHub Sync Low priority Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants