fix: sync/async calls in getSchedule#13387
Merged
keithwillcode merged 5 commits intomainfrom Jan 24, 2024
Merged
Conversation
keithwillcode
added
High priority
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Ignored Deployments
|
Contributor
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
joeauyeung
previously approved these changes
Jan 24, 2024
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 398 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 01/24/2024 02:53:17pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 196926b Started: 01/24/2024 02:47:07pm UTC
|
|
|
13 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
unauthorized user sees correct translations (de) should use correct translations and html attributes
Retry 1 • Initial Attempt |
-20% (-69)-69 / 345 runsfailed over last 7 days |
20.29% (70)70 / 345 runsflaked over last 7 days |
|
unauthorized user sees correct translations (ar) should use correct translations and html attributes
Retry 1 • Initial Attempt |
-20.35% (-70)-70 / 344 runsfailed over last 7 days |
20.35% (70)70 / 344 runsflaked over last 7 days |
|
unauthorized user sees correct translations (zh) should use correct translations and html attributes
Retry 1 • Initial Attempt |
-20.41% (-70)-70 / 343 runsfailed over last 7 days |
20.41% (70)70 / 343 runsflaked over last 7 days |
|
unauthorized user sees correct translations (zh-CN) should use correct translations and html attributes
Retry 1 • Initial Attempt |
-20.41% (-70)-70 / 343 runsfailed over last 7 days |
20.41% (70)70 / 343 runsflaked over last 7 days |
|
unauthorized user sees correct translations (zh-TW) should use correct translations and html attributes
Retry 1 • Initial Attempt |
-20.41% (-70)-70 / 343 runsfailed over last 7 days |
20.41% (70)70 / 343 runsflaked over last 7 days |
|
unauthorized user sees correct translations (pt) should use correct translations and html attributes
Retry 1 • Initial Attempt |
-20.41% (-70)-70 / 343 runsfailed over last 7 days |
20.41% (70)70 / 343 runsflaked over last 7 days |
|
unauthorized user sees correct translations (pt-br) should use correct translations and html attributes
Retry 1 • Initial Attempt |
-20.41% (-70)-70 / 343 runsfailed over last 7 days |
20.41% (70)70 / 343 runsflaked over last 7 days |
|
unauthorized user sees correct translations (es-419) should use correct translations and html attributes
Retry 1 • Initial Attempt |
-20.41% (-70)-70 / 343 runsfailed over last 7 days |
20.41% (70)70 / 343 runsflaked over last 7 days |
|
authorized user sees correct translations (de) should return correct translations and html attributes
Retry 1 • Initial Attempt |
-20.41% (-70)-70 / 343 runsfailed over last 7 days |
20.41% (70)70 / 343 runsflaked over last 7 days |
|
authorized user sees correct translations (pt-br) should return correct translations and html attributes
Retry 1 • Initial Attempt |
-20.41% (-70)-70 / 343 runsfailed over last 7 days |
20.41% (70)70 / 343 runsflaked over last 7 days |
|
authorized user sees correct translations (ar) should return correct translations and html attributes
Retry 1 • Initial Attempt |
-20.41% (-70)-70 / 343 runsfailed over last 7 days |
20.41% (70)70 / 343 runsflaked over last 7 days |
|
authorized user sees changed translations (de->ar) should return correct translations and html attributes
Retry 1 • Initial Attempt |
-8.21% (-28)-28 / 341 runsfailed over last 7 days |
18.77% (64)64 / 341 runsflaked over last 7 days |
|
authorized user sees changed translations (de->pt-BR) [locale1] should return correct translations and html attributes
Retry 1 • Initial Attempt |
-10.16% (-31)-31 / 305 runsfailed over last 7 days |
20.66% (63)63 / 305 runsflaked over last 7 days |
📄 apps/web/playwright/login.2fa.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 1 • Initial Attempt |
0.88% (3)3 / 340 runsfailed over last 7 days |
35% (119)119 / 340 runsflaked over last 7 days |
📄 apps/web/playwright/login.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
user can login & logout succesfully -- future login flow user & logout using dashboard
Retry 2 • Retry 1 • Initial Attempt |
37.70% (46)46 / 122 runsfailed over last 7 days |
35.25% (43)43 / 122 runsflaked over last 7 days |
📄 apps/web/playwright/booking/longTextQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Long Text Question and Each Other Question Booking With Long Text Question and Radio group Question Long Text required and Radio group not required
Retry 1 • Initial Attempt |
0.37% (1)1 / 269 runfailed over last 7 days |
3.72% (10)10 / 269 runsflaked over last 7 days |
📄 apps/web/playwright/booking/checkboxGroupQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and Phone Question Checkbox Group and Phone not required
Retry 1 • Initial Attempt |
0% (0)0 / 301 runsfailed over last 7 days |
1.99% (6)6 / 301 runsflaked over last 7 days |
📄 apps/web/playwright/availability.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Availablity tests Date Overrides
Retry 1 • Initial Attempt |
0.26% (1)1 / 391 runfailed over last 7 days |
3.58% (14)14 / 391 runsflaked over last 7 days |
…o fix/sync-async-issues
joeauyeung
approved these changes
Jan 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Incorrect calls that are currently triggered using sync logic instead of async logic, which could cause very weird side effects for getting a user's schedule.
Related to #13358
Type of change
How should this be tested?
getScheduletRPC endpoint retains correctly functionalityMandatory Tasks