fix: Booker shows toggle external calendar on external links#13395
Merged
ThyMinimalDev merged 1 commit intomainfrom Jan 24, 2024
Merged
fix: Booker shows toggle external calendar on external links#13395ThyMinimalDev merged 1 commit intomainfrom
ThyMinimalDev merged 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
Contributor
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
github-actions
Bot
added
High priority
keithwillcode
added
api
| "bg-default dark:bg-muted sticky top-0 z-10" | ||
| )}> | ||
| <Header | ||
| isMyLink={Boolean(username === event?.data?.owner?.username)} |
Contributor
There was a problem hiding this comment.
So that means somehow isMyLink was getting set to true somehow even using the username from the event?
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 419 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 01/24/2024 06:33:42pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 7bfd7f5 Started: 01/24/2024 06:23:24pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Phone Question and Each Other Question Booking With Select Question and Short text question Select and Short text not required
Retry 1 • Initial Attempt |
0.57% (2)2 / 351 runsfailed over last 7 days |
2.28% (8)8 / 351 runsflaked over last 7 days |
📄 apps/web/playwright/login.2fa.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 1 • Initial Attempt |
0.85% (3)3 / 351 runsfailed over last 7 days |
35.90% (126)126 / 351 runsflaked over last 7 days |
📄 apps/web/playwright/login.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
user can login & logout succesfully -- future login flow user & logout using dashboard
Retry 2 • Retry 1 • Initial Attempt |
39.85% (53)53 / 133 runsfailed over last 7 days |
34.59% (46)46 / 133 runsflaked over last 7 days |
📄 apps/web/playwright/booking/responsiveBooking.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking page with no questions Booking page with 640x480 resolution
Retry 1 • Initial Attempt |
0% (0)0 / 5 runsfailed over last 7 days |
20% (1)1 / 5 runflaked over last 7 days |
📄 apps/web/playwright/booking/radioGroupQuestion.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Radio Question and Each Other Question Booking With Radio Question and Address Question Booking With Radio Question and Number Question Radio and Number not required
Retry 1 • Initial Attempt |
0% (0)0 / 358 runsfailed over last 7 days |
3.63% (13)13 / 358 runsflaked over last 7 days |
|
Booking With Radio Question and Each Other Question Booking With Radio Question and Address Question Booking With Radio Question and Phone Question Radio required and Phone required
Retry 1 • Initial Attempt |
0% (0)0 / 358 runsfailed over last 7 days |
2.51% (9)9 / 358 runsflaked over last 7 days |
📄 apps/web/playwright/workflow.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Workflow Tab - Event Type Check the functionalities of the Workflow Tab User Workflows Create an action and check if workflow is triggered
Retry 1 • Initial Attempt |
2.56% (9)9 / 351 runsfailed over last 7 days |
11.68% (41)41 / 351 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests -- legacy user enabling recurring event comes with default options
Retry 1 • Initial Attempt |
0% (0)0 / 228 runsfailed over last 7 days |
5.26% (12)12 / 228 runsflaked over last 7 days |
📄 apps/web/playwright/signup.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Signup Flow Test Username is taken
Retry 1 • Initial Attempt |
0% (0)0 / 386 runsfailed over last 7 days |
0.52% (2)2 / 386 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes
Top 1 Common Error Messages
|
|
8 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
1.03% (4)4 / 388 runsfailed over last 7 days |
55.93% (217)217 / 388 runsflaked over last 7 days |
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
-83.01% (-171)-171 / 206 runsfailed over last 7 days |
114.56% (236)236 / 206 runsflaked over last 7 days |
|
Popup Tests should open Routing Forms embed on click
Retry 1 • Initial Attempt |
-86.76% (-177)-177 / 204 runsfailed over last 7 days |
100% (204)204 / 204 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
-86.27% (-176)-176 / 204 runsfailed over last 7 days |
110.78% (226)226 / 204 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1 • Initial Attempt |
-86.27% (-176)-176 / 204 runsfailed over last 7 days |
86.27% (176)176 / 204 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-86.27% (-176)-176 / 204 runsfailed over last 7 days |
86.27% (176)176 / 204 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-86.27% (-176)-176 / 204 runsfailed over last 7 days |
86.27% (176)176 / 204 runsflaked over last 7 days |
|
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1 • Initial Attempt |
-86.70% (-176)-176 / 203 runsfailed over last 7 days |
86.70% (176)176 / 203 runsflaked over last 7 days |
📄 apps/web/playwright/booking/addressQuestione2e/addressQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Address Question and Each Other Question Booking With Address Question and Long text Question Address and Long Text not required
Retry 1 • Initial Attempt |
0.83% (3)3 / 362 runsfailed over last 7 days |
2.76% (10)10 / 362 runsflaked over last 7 days |
keithwillcode
approved these changes
Jan 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #13393
Type of change
How should this be tested?
Mandatory Tasks