Skip to content

chore: optimizing bundle size#13473

Merged
keithwillcode merged 2 commits intomainfrom
chore/fix-imports
Jan 30, 2024
Merged

chore: optimizing bundle size#13473
keithwillcode merged 2 commits intomainfrom
chore/fix-imports

Conversation

@zomars
Copy link
Copy Markdown
Contributor

@zomars zomars commented Jan 30, 2024

What does this PR do?

Testing some fixes to improve bundle size. Mostly from Sentry. getsentry/sentry-javascript#7680

Fixes various imports bundle size:

Before:

image

After:

image

Before

image

After

image

Requirement/Documentation

  • If there is a requirement document, please, share it here.
  • If there is ab UI/UX design document, please, share it here.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Tests (Unit/Integration/E2E or any other test)
  • This change requires a documentation update

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2024 8:12pm
6 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2024 8:12pm
cal ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2024 8:12pm
cal-demo ⬜️ Ignored (Inspect) Jan 30, 2024 8:12pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2024 8:12pm
qa ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2024 8:12pm
ui ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2024 8:12pm

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 30, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 30, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link
Copy Markdown

deploysentinel Bot commented Jan 30, 2024

Current Playwright Test Results Summary

✅ 92 Passing - ⚠️ 5 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 01/30/2024 10:21:43pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: b6b8d64

Started: 01/30/2024 10:15:02pm UTC

⚠️ Flakes

📄   apps/web/playwright/booking/checkboxGroupQuestion.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and Long text Question Checkbox Group required and Long text required
Retry 1Initial Attempt
0% (0) 0 / 279 runs
failed over last 7 days
2.15% (6) 6 / 279 runs
flaked over last 7 days
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and Long text Question Checkbox Group and Long text not required
Retry 1Initial Attempt
0% (0) 0 / 279 runs
failed over last 7 days
3.58% (10) 10 / 279 runs
flaked over last 7 days

📄   apps/web/playwright/booking/availability.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Check availability tab in a event-type Check availability in event type
Retry 1Initial Attempt
17.31% (49) 49 / 283 runs
failed over last 7 days
43.11% (122) 122 / 283 runs
flaked over last 7 days

📄   apps/web/playwright/booking/allQuestions.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With All Questions Selecting and filling all questions as optional
Retry 1Initial Attempt
0.36% (1) 1 / 280 run
failed over last 7 days
2.86% (8) 8 / 280 runs
flaked over last 7 days

📄   apps/web/playwright/booking/addressQuestione2e/addressQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Address Question and Each Other Question Booking With Address Question and Long text Question Address and Long Text not required
Retry 1Initial Attempt
0% (0) 0 / 289 runs
failed over last 7 days
4.50% (13) 13 / 289 runs
flaked over last 7 days

View Detailed Build Results


@zomars zomars marked this pull request as ready for review January 30, 2024 20:08
@zomars zomars requested a review from a team January 30, 2024 20:08
@keithwillcode keithwillcode added this to the v3.8 milestone Jan 30, 2024
@keithwillcode keithwillcode enabled auto-merge (squash) January 30, 2024 22:48
@keithwillcode keithwillcode merged commit 7d1c698 into main Jan 30, 2024
@keithwillcode keithwillcode deleted the chore/fix-imports branch January 30, 2024 22:49
@emrysal
Copy link
Copy Markdown
Contributor

emrysal commented Jan 30, 2024

Nice one @zomars !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api area: API, enterprise API, access token, OAuth core area: core, team members only foundation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants