chore: optimizing bundle size#13473
Merged
keithwillcode merged 2 commits intomainfrom Jan 30, 2024
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Ignored Deployments
|
Contributor
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 92 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 01/30/2024 10:21:43pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: b6b8d64 Started: 01/30/2024 10:15:02pm UTC
|
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and Long text Question Checkbox Group required and Long text required
Retry 1 • Initial Attempt |
0% (0)0 / 279 runsfailed over last 7 days |
2.15% (6)6 / 279 runsflaked over last 7 days |
|
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and Long text Question Checkbox Group and Long text not required
Retry 1 • Initial Attempt |
0% (0)0 / 279 runsfailed over last 7 days |
3.58% (10)10 / 279 runsflaked over last 7 days |
📄 apps/web/playwright/booking/availability.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Check availability tab in a event-type Check availability in event type
Retry 1 • Initial Attempt |
17.31% (49)49 / 283 runsfailed over last 7 days |
43.11% (122)122 / 283 runsflaked over last 7 days |
📄 apps/web/playwright/booking/allQuestions.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With All Questions Selecting and filling all questions as optional
Retry 1 • Initial Attempt |
0.36% (1)1 / 280 runfailed over last 7 days |
2.86% (8)8 / 280 runsflaked over last 7 days |
📄 apps/web/playwright/booking/addressQuestione2e/addressQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Address Question and Each Other Question Booking With Address Question and Long text Question Address and Long Text not required
Retry 1 • Initial Attempt |
0% (0)0 / 289 runsfailed over last 7 days |
4.50% (13)13 / 289 runsflaked over last 7 days |
keithwillcode
approved these changes
Jan 30, 2024
Contributor
|
Nice one @zomars ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Testing some fixes to improve bundle size. Mostly from Sentry. getsentry/sentry-javascript#7680
Fixes various imports bundle size:
Before:
After:
Before
After
Requirement/Documentation
Type of change
How should this be tested?
Mandatory Tasks
Checklist