chore: uses safeGet to be more explicit#13543
Merged
keithwillcode merged 5 commits intomainfrom Feb 5, 2024
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
Contributor
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
Contributor
Author
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
keithwillcode
added
api
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 440 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 02/05/2024 08:18:38pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 41cc649 Started: 02/05/2024 08:09:02pm UTC
|
|
|
3 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Phone Question and Each Other Question Booking With Select Question and Address Question Select required and Address required
Retry 1 • Initial Attempt |
0% (0)0 / 254 runsfailed over last 7 days |
3.54% (9)9 / 254 runsflaked over last 7 days |
|
Booking With Phone Question and Each Other Question Booking With Select Question and Number Question Select and Number not required
Retry 1 • Initial Attempt |
0% (0)0 / 250 runsfailed over last 7 days |
2% (5)5 / 250 runsflaked over last 7 days |
|
Booking With Phone Question and Each Other Question Booking With Select Question and Radio group Question Select required and Radio group required
Retry 1 • Initial Attempt |
0% (0)0 / 248 runsfailed over last 7 days |
6.05% (15)15 / 248 runsflaked over last 7 days |
📄 apps/web/playwright/booking/responsiveBooking.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking page with no questions Booking page with 1920x1080 resolution
Retry 1 • Initial Attempt |
0% (0)0 / 255 runsfailed over last 7 days |
2.75% (7)7 / 255 runsflaked over last 7 days |
📄 apps/web/playwright/booking/longTextQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Long Text Question and Each Other Question Booking With Long Text Question and Phone Question Long Text required and Phone not required
Retry 1 • Initial Attempt |
0.38% (1)1 / 265 runfailed over last 7 days |
3.40% (9)9 / 265 runsflaked over last 7 days |
📄 apps/web/playwright/login.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
user can login & logout succesfully -- future login flow user & logout using dashboard
Retry 1 • Initial Attempt |
3% (8)8 / 267 runsfailed over last 7 days |
40.07% (107)107 / 267 runsflaked over last 7 days |
📄 apps/web/playwright/booking/radioGroupQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Radio Question and Each Other Question Booking With Radio Question and Address Question Booking With Radio Question and Phone Question Radio and Phone not required
Retry 1 • Initial Attempt |
0.38% (1)1 / 261 runfailed over last 7 days |
3.83% (10)10 / 261 runsflaked over last 7 days |
📄 apps/web/playwright/booking/checkboxGroupQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and Multi email Question Checkbox Group and Multi email not required
Retry 1 • Initial Attempt |
0% (0)0 / 275 runsfailed over last 7 days |
5.45% (15)15 / 275 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes
Top 1 Common Error Messages
|
|
8 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
-3.50% (-10)-10 / 286 runsfailed over last 7 days |
46.15% (132)132 / 286 runsflaked over last 7 days |
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
-80.98% (-132)-132 / 163 runsfailed over last 7 days |
80.98% (132)132 / 163 runsflaked over last 7 days |
|
Popup Tests should open Routing Forms embed on click
Retry 1 • Initial Attempt |
-69.94% (-114)-114 / 163 runsfailed over last 7 days |
72.39% (118)118 / 163 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
-74.21% (-118)-118 / 159 runsfailed over last 7 days |
74.21% (118)118 / 159 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1 • Initial Attempt |
-74.21% (-118)-118 / 159 runsfailed over last 7 days |
74.21% (118)118 / 159 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-74.21% (-118)-118 / 159 runsfailed over last 7 days |
74.21% (118)118 / 159 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-74.21% (-118)-118 / 159 runsfailed over last 7 days |
74.21% (118)118 / 159 runsflaked over last 7 days |
|
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1 • Initial Attempt |
-74.21% (-118)-118 / 159 runsfailed over last 7 days |
74.21% (118)118 / 159 runsflaked over last 7 days |
📄 apps/web/playwright/booking/phoneQuestion.e2e.ts • 3 Flakes
Top 1 Common Error Messages
|
|
3 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Phone Question and Each Other Question Booking With Phone Question and Address Question Booking With Phone Question and checkbox Question Phone and checkbox required
Retry 1 • Initial Attempt |
0.73% (2)2 / 275 runsfailed over last 7 days |
4.73% (13)13 / 275 runsflaked over last 7 days |
|
Booking With Phone Question and Each Other Question Booking With Phone Question and Address Question Booking With Phone Question and checkbox Question Phone required and checkbox not required
Retry 1 • Initial Attempt |
0.73% (2)2 / 275 runsfailed over last 7 days |
7.27% (20)20 / 275 runsflaked over last 7 days |
|
Booking With Phone Question and Each Other Question Booking With Phone Question and Address Question Booking With Phone Question and Long text Question Phone and Long text required
Retry 1 • Initial Attempt |
0.36% (1)1 / 274 runfailed over last 7 days |
4.74% (13)13 / 274 runsflaked over last 7 days |
keithwillcode
approved these changes
Feb 5, 2024
emrysal
approved these changes
Feb 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes safeGet function so it's more explicit that this is the pattern to use when accessing edge configs.