fix: open reporting in new tab full screen#13659
Merged
CarinaWolli merged 9 commits intoMar 12, 2024
Merged
Conversation
Member
PeerRich
commented
Feb 13, 2024
PeerRich
commented
github-actions
Bot
added
routing-forms
Contributor
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Ignored Deployments
|
PeerRich
removed
the
🚨 needs approval
PeerRich
added
⚡ Quick Wins
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 311 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 03/12/2024 03:43:05pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 434b8b5 Started: 03/12/2024 03:36:51pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
pro user -- future Can cancel the recently created booking and shouldn't be allowed to reschedule it
Retry 1 • Initial Attempt |
0% (0)0 / 209 runsfailed over last 7 days |
0.48% (1)1 / 209 runflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests -- future user Different Locations Tests Can remove location from multiple locations that are saved
Retry 1 • Initial Attempt |
0.47% (1)1 / 211 runfailed over last 7 days |
8.53% (18)18 / 211 runsflaked over last 7 days |
|
Event Types tests -- legacy user Different Locations Tests Can remove location from multiple locations that are saved
Retry 1 • Initial Attempt |
0.48% (1)1 / 209 runfailed over last 7 days |
18.18% (38)38 / 209 runsflaked over last 7 days |
📄 apps/web/playwright/impersonation.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Users can impersonate App Admin can impersonate users with impersonation enabled
Retry 1 • Initial Attempt |
0% (0)0 / 209 runsfailed over last 7 days |
9.09% (19)19 / 209 runsflaked over last 7 days |
📄 apps/web/playwright/profile.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Update Profile Can update a users email (verification enabled)
Retry 1 • Initial Attempt |
5.83% (12)12 / 206 runsfailed over last 7 days |
23.30% (48)48 / 206 runsflaked over last 7 days |
📄 apps/web/playwright/organization/organization-invitation.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Organization Email not matching orgAutoAcceptEmail nonexisting user invited to an organization
Retry 1 • Initial Attempt |
1.09% (2)2 / 184 runsfailed over last 7 days |
11.41% (21)21 / 184 runsflaked over last 7 days |
📄 apps/web/playwright/apps/analytics/analyticsApps.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Check analytics Apps Check analytics Apps
Retry 1 • Initial Attempt |
0.45% (1)1 / 222 runfailed over last 7 days |
4.95% (11)11 / 222 runsflaked over last 7 days |
📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Router URL should work
Retry 1 • Initial Attempt |
0% (0)0 / 224 runsfailed over last 7 days |
9.82% (22)22 / 224 runsflaked over last 7 days |
Udit-takkar
reviewed
Feb 14, 2024
Contributor
Udit-takkar
left a comment
Udit-takkar
left a comment
There was a problem hiding this comment.
Screen.Recording.2024-02-14.at.1.42.37.PM.mov
- can't see some elements when banner is active
- hydration err
hariombalhara
previously approved these changes
Feb 15, 2024
…s-reporting-in-new-tab' into 13658-cal-3123-open-routing-forms-reporting-in-new-tab
hariombalhara
force-pushed
the
13658-cal-3123-open-routing-forms-reporting-in-new-tab
branch
from
14f44a3 to
82eb8eb
Compare
CarinaWolli
requested changes
Feb 21, 2024
Member
CarinaWolli
left a comment
CarinaWolli
left a comment
There was a problem hiding this comment.
Banner on top and mobile view needs to be fixed
Mobile:
PeerRich
commented
Mar 12, 2024
Member
Author
|
fixed |
CarinaWolli
approved these changes
Mar 12, 2024
CarinaWolli
deleted the
13658-cal-3123-open-routing-forms-reporting-in-new-tab
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.