feat: new privacy settings for orgs by PeerRich · Pull Request #13693 · calcom/cal.diy

PeerRich · 2024-02-14T19:01:23Z

linear · 2024-02-14T19:01:26Z

github-actions · 2024-02-14T19:01:35Z

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

vercel · 2024-02-14T19:05:45Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
cal	🛑 Canceled (Inspect)			Mar 12, 2024 4:21pm

3 Ignored Deployments

Name	Status	Preview	Updated (UTC)
ai	⬜️ Ignored (Inspect)	Visit Preview	Mar 12, 2024 4:21pm
calcom-web-canary	⬜️ Ignored (Inspect)	Visit Preview	Mar 12, 2024 4:21pm
qa	⬜️ Ignored (Inspect)	Visit Preview	Mar 12, 2024 4:21pm

github-actions · 2024-02-14T19:14:17Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

New Page Added

The following page was added to the bundle from the code in this PR:

Page	Size (compressed)	First Load	% of Budget (`350 KB`)
`/settings/organizations/privacy`	`270.66 KB`	459.06 KB	131.16%

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load	% of Budget (`350 KB`)
`/settings/organizations/members`	`433.98 KB`	622.37 KB	177.82% (🟢 -1.31%)

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

deploysentinel · 2024-02-14T19:15:12Z

Current Playwright Test Results Summary

✅ 311 Passing - ⚠️ 12 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 03/12/2024 03:55:35pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: c309bc5

Started: 03/12/2024 03:51:22pm UTC

⚠️ Flakes

📄 apps/web/playwright/login.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
user can login & logout succesfully -- future login flow user & logout using dashboard Retry 1 • Initial Attempt	0.95% (2) 2 / 211 runs failed over last 7 days	26.07% (55) 55 / 211 runs flaked over last 7 days

📄 apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Event Types tests -- future user Different Locations Tests can add Attendee Phone Number location and book with it Retry 1 • Initial Attempt	4.42% (10) 10 / 226 runs failed over last 7 days	3.98% (9) 9 / 226 runs flaked over last 7 days

📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes

Top 1 Common Error Messages

`null`	8 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Popup Tests should open embed iframe on click - Configured with light theme Retry 1 • Initial Attempt	5.29% (12) 12 / 227 runs failed over last 7 days	44.05% (100) 100 / 227 runs flaked over last 7 days
Popup Tests should be able to reschedule Retry 1 • Initial Attempt	-86.96% (-100) -100 / 115 runs failed over last 7 days	86.96% (100) 100 / 115 runs flaked over last 7 days
Popup Tests should open Routing Forms embed on click Retry 1 • Initial Attempt	-86.09% (-99) -99 / 115 runs failed over last 7 days	86.09% (99) 99 / 115 runs flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API Retry 1 • Initial Attempt	-86.09% (-99) -99 / 115 runs failed over last 7 days	86.09% (99) 99 / 115 runs flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API Retry 1 • Initial Attempt	-86.09% (-99) -99 / 115 runs failed over last 7 days	86.09% (99) 99 / 115 runs flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API Retry 1 • Initial Attempt	-86.09% (-99) -99 / 115 runs failed over last 7 days	86.09% (99) 99 / 115 runs flaked over last 7 days
Popup Tests prendered embed should be loaded and apply the config given to it Retry 1 • Initial Attempt	-86.09% (-99) -99 / 115 runs failed over last 7 days	86.09% (99) 99 / 115 runs flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API Retry 1 • Initial Attempt	-86.09% (-99) -99 / 115 runs failed over last 7 days	86.09% (99) 99 / 115 runs flaked over last 7 days

📄 apps/web/playwright/integrations-stripe.e2e.ts • 2 Flakes

Top 1 Common Error Messages

`null`	2 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Stripe integration Can book a paid booking Retry 1 • Initial Attempt	6.19% (14) 14 / 226 runs failed over last 7 days	30.97% (70) 70 / 226 runs flaked over last 7 days
Stripe integration Pending payment booking should not be confirmed by default Retry 1 • Initial Attempt	5.75% (13) 13 / 226 runs failed over last 7 days	21.24% (48) 48 / 226 runs flaked over last 7 days

View Detailed Build Results

PeerRich · 2024-02-14T19:17:10Z

+      {/* TODO: add mutations and logic
+      {isOrg && (
+        <>
+          <SettingsToggle
+            toggleSwitchAtTheEnd={true}
+            title={t("hide_all_teams")}
+            disabled={disabled || mutation?.isPending}
+            description={t("hide_all_teams_description")}
+            checked={isTeamPrivate}
+            onCheckedChange={(checked) => {
+              setTeamPrivate(checked);
+              mutation.mutate({ id: teamId, isPrivate: checked });


need help here. can be a follow up PR

@PeerRich I think i already implemented hiding members for team. if you check the 'make team private' switch then you won't be able to see members

should i create separate switches for 'hiding event types', 'hiding members' and 'hiding team in orgs'? then what would 'Make team private switch' do?

CarinaWolli

I fixed a type error but there are more, @Udit-takkar can you fix them? Added some minor clean up comments, but other than that it looks good 🙏

CarinaWolli

Looks good 🙏

PeerRich · 2024-03-12T15:28:38Z

thank you @Udit-takkar for taking this over 🙏

PeerRich · 2024-03-12T15:41:58Z

fixes #13421

PeerRich added 2 commits February 14, 2024 18:59

moved privacy setting to new tab

c1d61eb

i18n

180181f

PeerRich linked an issue Feb 14, 2024 that may be closed by this pull request

[CAL-3143] "Privacy" tab for Orgs #13691

Closed

github-actions Bot added enterprise area: enterprise, audit log, organisation, SAML, SSO ✨ feature New feature or request 🎨 needs design Before engineering kick-off, a designer needs to submit a mockup labels Feb 14, 2024

keithwillcode added the core area: core, team members only label Feb 14, 2024

vercel Bot deployed to Preview – ai February 14, 2024 19:08 View deployment

vercel Bot deployed to Preview – api February 14, 2024 19:11 View deployment

added more privacy switches

e6c9e63

vercel Bot deployed to Preview – dev February 14, 2024 19:15 View deployment

PeerRich marked this pull request as draft February 14, 2024 19:16

PeerRich commented Feb 14, 2024

View reviewed changes

vercel Bot deployed to Preview – api February 14, 2024 19:22 View deployment

vercel Bot deployed to Preview – dev February 14, 2024 19:31 View deployment

keithwillcode added this to the v3.9 milestone Feb 14, 2024

keithwillcode requested a review from a team February 14, 2024 21:33

keithwillcode assigned hariombalhara and Udit-takkar and unassigned hariombalhara Feb 20, 2024

fix: hide org teams and members

5e32226

github-actions Bot added the High priority Created by Linear-GitHub Sync label Feb 21, 2024

fix: use i18n

66363c9

vercel Bot deployed to Preview – api February 21, 2024 20:31 View deployment

PeerRich removed the High priority Created by Linear-GitHub Sync label Feb 21, 2024

CarinaWolli reviewed Mar 8, 2024

View reviewed changes

Comment thread apps/web/public/static/locales/en/common.json Outdated

Comment thread packages/features/ee/organizations/pages/settings/members.tsx Outdated

Comment thread packages/features/ee/teams/components/MakeTeamPrivateSwitch.tsx Outdated

Merge branch 'main' into 13691-cal-3143-privacy-tab-for-orgs

fa18332

vercel Bot deployed to Preview – ai March 11, 2024 15:12 View deployment

vercel Bot deployed to Preview – api March 11, 2024 15:15 View deployment

vercel Bot deployed to Preview – dev March 11, 2024 15:24 View deployment

Udit-takkar added 2 commits March 12, 2024 09:03

chore: type err

df4d597

chore: feedback

263fd80

vercel Bot deployed to Preview – api March 12, 2024 03:43 View deployment

Udit-takkar and others added 2 commits March 12, 2024 09:29

chore: type err

c61640d

Merge branch 'main' into 13691-cal-3143-privacy-tab-for-orgs

498637c

Udit-takkar requested a review from CarinaWolli March 12, 2024 04:03

vercel Bot deployed to Preview – ai March 12, 2024 04:05 View deployment

vercel Bot deployed to Preview – api March 12, 2024 04:10 View deployment

vercel Bot deployed to Preview – dev March 12, 2024 04:31 View deployment

CarinaWolli approved these changes Mar 12, 2024

View reviewed changes

Merge branch 'main' into 13691-cal-3143-privacy-tab-for-orgs

64592b8

CarinaWolli enabled auto-merge (squash) March 12, 2024 15:28

PeerRich modified the milestones: v4.0, v3.9 Mar 12, 2024

PeerRich added Medium priority Created by Linear-GitHub Sync and removed High priority Created by Linear-GitHub Sync labels Mar 12, 2024

Merge branch 'main' into 13691-cal-3143-privacy-tab-for-orgs

c309bc5

github-actions Bot added the High priority Created by Linear-GitHub Sync label Mar 12, 2024

PeerRich mentioned this pull request Mar 12, 2024

[CAL-3034] move "make organistion private" settings into "General" #13421

Closed

CarinaWolli merged commit f2478ea into main Mar 12, 2024

CarinaWolli deleted the 13691-cal-3143-privacy-tab-for-orgs branch March 12, 2024 15:56

vercel Bot deployed to Preview – api March 12, 2024 16:05 View deployment

vercel Bot deployed to Preview – dev March 12, 2024 16:11 View deployment

Conversation

PeerRich commented Feb 14, 2024

Uh oh!

linear Bot commented Feb 14, 2024

Uh oh!

github-actions Bot commented Feb 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel Bot commented Feb 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Feb 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Next.js Bundle Analysis for @calcom/web

New Page Added

One Page Changed Size

Uh oh!

deploysentinel Bot commented Feb 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current Playwright Test Results Summary

⚠️ Flakes

Test Case Results

Test Case Results

Top 1 Common Error Messages

Test Case Results

Top 1 Common Error Messages

Test Case Results

Uh oh!

PeerRich Feb 14, 2024

Choose a reason for hiding this comment

Uh oh!

Udit-takkar Feb 21, 2024

Choose a reason for hiding this comment

Uh oh!

Udit-takkar Feb 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CarinaWolli left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CarinaWolli left a comment

Choose a reason for hiding this comment

Uh oh!

PeerRich commented Mar 12, 2024

Uh oh!

PeerRich commented Mar 12, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

github-actions Bot commented Feb 14, 2024 •

edited

Loading

vercel Bot commented Feb 14, 2024 •

edited

Loading

github-actions Bot commented Feb 14, 2024 •

edited

Loading

deploysentinel Bot commented Feb 14, 2024 •

edited

Loading

Udit-takkar Feb 21, 2024 •

edited

Loading