Skip to content

fix: hide hidden fields on booking page#13843

Merged
CarinaWolli merged 8 commits intomainfrom
fix/hide-response
Mar 13, 2024
Merged

fix: hide hidden fields on booking page#13843
CarinaWolli merged 8 commits intomainfrom
fix/hide-response

Conversation

@Udit-takkar
Copy link
Copy Markdown
Contributor

@Udit-takkar Udit-takkar commented Feb 23, 2024

What does this PR do?

Fixes #13841

  • Hide hidden fields on success page (only for attendee)
  • Hide Hidden fields on email (only for attendee)

Before

Screenshot 2024-02-24 at 5 19 47 AM

After:-

Screenshot 2024-02-24 at 5 19 08 AM

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@graphite-app graphite-app Bot requested a review from a team February 23, 2024 23:48
@github-actions github-actions Bot added Medium priority Created by Linear-GitHub Sync ✨ feature New feature or request 🐛 bug Something isn't working labels Feb 23, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 23, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@keithwillcode keithwillcode added consumer core area: core, team members only labels Feb 23, 2024
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Feb 23, 2024

Graphite Automations

A Graphite automation took an action on this PR • (02/23/24)

1 reviewer was added based on Keith Williams's automation, 'Add consumer team as reviewer'

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview Mar 13, 2024 3:25pm
cal ⬜️ Ignored (Inspect) Visit Preview Mar 13, 2024 3:25pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Mar 13, 2024 3:25pm
qa ⬜️ Ignored (Inspect) Visit Preview Mar 13, 2024 3:25pm

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 23, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link
Copy Markdown

deploysentinel Bot commented Feb 24, 2024

Current Playwright Test Results Summary

✅ 303 Passing - ⚠️ 12 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 03/13/2024 03:33:46pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 12d1762

Started: 03/13/2024 03:30:26pm UTC

⚠️ Flakes

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests -- future user can add multiple organizer address
Retry 1Initial Attempt
4.74% (11) 11 / 232 runs
failed over last 7 days
13.79% (32) 32 / 232 runs
flaked over last 7 days

📄   apps/web/playwright/booking-seats.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Reschedule for booking with seats If rescheduled/cancelled booking with seats it should display the correct number of seats
Retry 1Initial Attempt
0% (0) 0 / 217 runs
failed over last 7 days
4.15% (9) 9 / 217 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes

Top 1 Common Error Messages

null

8 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1Initial Attempt
5.15% (12) 12 / 233 runs
failed over last 7 days
45.49% (106) 106 / 233 runs
flaked over last 7 days
Popup Tests should be able to reschedule
Retry 1Initial Attempt
-92.17% (-106) -106 / 115 runs
failed over last 7 days
92.17% (106) 106 / 115 runs
flaked over last 7 days
Popup Tests should open Routing Forms embed on click
Retry 1Initial Attempt
-91.30% (-105) -105 / 115 runs
failed over last 7 days
91.30% (105) 105 / 115 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1Initial Attempt
-91.30% (-105) -105 / 115 runs
failed over last 7 days
91.30% (105) 105 / 115 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-91.30% (-105) -105 / 115 runs
failed over last 7 days
91.30% (105) 105 / 115 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1Initial Attempt
-91.30% (-105) -105 / 115 runs
failed over last 7 days
91.30% (105) 105 / 115 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-91.30% (-105) -105 / 115 runs
failed over last 7 days
91.30% (105) 105 / 115 runs
flaked over last 7 days
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1Initial Attempt
-91.30% (-105) -105 / 115 runs
failed over last 7 days
91.30% (105) 105 / 115 runs
flaked over last 7 days

📄   apps/web/playwright/change-theme.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Change Theme Test change theme to light
Retry 1Initial Attempt
0% (0) 0 / 235 runs
failed over last 7 days
0.43% (1) 1 / 235 run
flaked over last 7 days

📄   packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Routing Forms Seeded Routing Form Router URL should work
Retry 1Initial Attempt
0% (0) 0 / 233 runs
failed over last 7 days
12.45% (29) 29 / 233 runs
flaked over last 7 days

View Detailed Build Results


Copy link
Copy Markdown
Member

@CarinaWolli CarinaWolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 🙏

@CarinaWolli CarinaWolli merged commit 76b3316 into main Mar 13, 2024
@CarinaWolli CarinaWolli deleted the fix/hide-response branch March 13, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working consumer core area: core, team members only ✨ feature New feature or request Medium priority Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-3206] [CAL-3205] do not show hidden booking questions to guests

3 participants