fix: Redirect URL with query params#13912
Conversation
|
@fusionUI is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
|
Vikas Verma seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
github-actions
Bot
added
⚡ Quick Wins
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
Graphite AutomationsA Graphite automation took an action on this PR • (02/28/24)1 reviewer was added based on Keith Williams's automation, 'Add consumer team as reviewer' A Graphite automation took an action on this PR • (02/28/24)1 label was added based on Keith Williams's automation, 'Add community label' |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Seventy-seven Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
keithwillcode
changed the title
Udit-takkar
left a comment
Udit-takkar
left a comment
There was a problem hiding this comment.
@vikas-verma I tried adding a url with query param and i got redirected to invalid url with two query params and params should be encoded
@Udit-takkar can you share the exact URL you tried, that will help. |
|
@vikas-verma take any test url https://www.google.com/search?q=tst 
|
|
@Udit-takkar pls verify |
Udit-takkar
left a comment
Udit-takkar
left a comment
There was a problem hiding this comment.
It's still not generating a valid url
|
This PR is being marked as stale due to inactivity. |
anikdhabal
left a comment
anikdhabal
left a comment
There was a problem hiding this comment.
LGTM, I've updated the code
|
E2E failing |
* Fix for issue calcom#13899 Redirect URL * Update bookingSuccessRedirect.ts * Update bookingSuccessRedirect.ts * fix: url params * chore: remove unused * chore: remove comment * Update --------- Co-authored-by: Vikas Verma <inboxvikasverma@gmail.com> Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com> Co-authored-by: Udit Takkar <udit222001@gmail.com> Co-authored-by: Anik Dhabal Babu <81948346+anikdhabal@users.noreply.github.com>
6 participants
Fixes #13899
Requirement/Documentation
Type of change
How should this be tested?
Mandatory Tasks
Checklist