Skip to content

fix: duplicate event type dialog#14055

Merged
emrysal merged 1 commit into
mainfrom
fix/duplicate-dialog
Mar 11, 2024
Merged

fix: duplicate event type dialog#14055
emrysal merged 1 commit into
mainfrom
fix/duplicate-dialog

Conversation

@Udit-takkar
Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes # (issue)
Screenshot 2024-03-11 at 8 25 26 PM

https://threads.com/thread/34567124690/34567124692?s=siXv1z8oKZfGEFXQ8KZpqe

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2024 2:56pm

@github-actions
Copy link
Copy Markdown
Contributor

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@keithwillcode keithwillcode added consumer core area: core, team members only labels Mar 11, 2024
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Mar 11, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (03/11/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@github-actions
Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link
Copy Markdown

deploysentinel Bot commented Mar 11, 2024

Current Playwright Test Results Summary

✅ 303 Passing - ⚠️ 13 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 03/11/2024 03:09:51pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: cb12d67

Started: 03/11/2024 03:06:02pm UTC

⚠️ Flakes

📄   apps/web/playwright/profile.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Update Profile Can update a users email (verification enabled)
Retry 2Retry 1Initial Attempt
5.39% (11) 11 / 204 runs
failed over last 7 days
23.53% (48) 48 / 204 runs
flaked over last 7 days

📄   apps/web/playwright/teams.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Teams - NonOrg -- future Email Embeds slots are loading for team event types
Retry 1Initial Attempt
40.43% (57) 57 / 141 runs
failed over last 7 days
23.40% (33) 33 / 141 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes

Top 1 Common Error Messages

null

8 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1Initial Attempt
4.93% (11) 11 / 223 runs
failed over last 7 days
46.64% (104) 104 / 223 runs
flaked over last 7 days
Popup Tests should be able to reschedule
Retry 1Initial Attempt
-96.30% (-104) -104 / 108 runs
failed over last 7 days
96.30% (104) 104 / 108 runs
flaked over last 7 days
Popup Tests should open Routing Forms embed on click
Retry 1Initial Attempt
-94.44% (-102) -102 / 108 runs
failed over last 7 days
94.44% (102) 102 / 108 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1Initial Attempt
-93.52% (-101) -101 / 108 runs
failed over last 7 days
93.52% (101) 101 / 108 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1Initial Attempt
-93.52% (-101) -101 / 108 runs
failed over last 7 days
93.52% (101) 101 / 108 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-93.52% (-101) -101 / 108 runs
failed over last 7 days
93.52% (101) 101 / 108 runs
flaked over last 7 days
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1Initial Attempt
-93.52% (-101) -101 / 108 runs
failed over last 7 days
93.52% (101) 101 / 108 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-93.52% (-101) -101 / 108 runs
failed over last 7 days
93.52% (101) 101 / 108 runs
flaked over last 7 days

📄   apps/web/playwright/organization/organization-creation.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Organization Admin should be able to create an organization and complete onboarding
Retry 2Retry 1Initial Attempt
3.74% (8) 8 / 214 runs
failed over last 7 days
0.93% (2) 2 / 214 runs
flaked over last 7 days

📄   apps/web/playwright/signup.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Signup Flow Test Signup with valid (non premium) username
Retry 1Initial Attempt
0.43% (1) 1 / 231 run
failed over last 7 days
8.23% (19) 19 / 231 runs
flaked over last 7 days

📄   apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Stripe integration Can book a paid booking
Retry 1Initial Attempt
5.45% (12) 12 / 220 runs
failed over last 7 days
28.64% (63) 63 / 220 runs
flaked over last 7 days

View Detailed Build Results


Copy link
Copy Markdown
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 👍

@emrysal emrysal merged commit 1482d9a into main Mar 11, 2024
@emrysal emrysal deleted the fix/duplicate-dialog branch March 11, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

consumer core area: core, team members only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants