Merged
Conversation
Closed
Contributor
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Ignored Deployments
|
PeerRich
commented
Mar 15, 2024
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Ninety-six Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
Current Playwright Test Results Summary✅ 303 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 03/28/2024 01:52:50pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: a2c1dff Started: 03/28/2024 01:49:05pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests -- legacy user Different Locations Tests Can remove location from multiple locations that are saved
Retry 1 • Initial Attempt |
0% (0)0 / 186 runsfailed over last 7 days |
20.43% (38)38 / 186 runsflaked over last 7 days |
📄 apps/web/playwright/eventType/limit-tab.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Limits Tab - Event Type Check the functionalities of the Limits Tab
Retry 1 • Initial Attempt |
0% (0)0 / 186 runsfailed over last 7 days |
4.84% (9)9 / 186 runsflaked over last 7 days |
📄 apps/web/playwright/profile.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Update Profile Newly added secondary email should show as Unverified
Retry 1 • Initial Attempt |
0% (0)0 / 187 runsfailed over last 7 days |
6.42% (12)12 / 187 runsflaked over last 7 days |
|
Update Profile Can resend verification link if the secondary email is unverified
Retry 1 • Initial Attempt |
8.02% (15)15 / 187 runsfailed over last 7 days |
24.60% (46)46 / 187 runsflaked over last 7 days |
📄 apps/web/playwright/team/team-invitation.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Team Invitation (non verified)
Retry 1 • Initial Attempt |
0% (0)0 / 200 runsfailed over last 7 days |
4.50% (9)9 / 200 runsflaked over last 7 days |
📄 apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Stripe integration Can book a paid booking
Retry 1 • Initial Attempt |
1.52% (3)3 / 197 runsfailed over last 7 days |
40.10% (79)79 / 197 runsflaked over last 7 days |
Graphite Automations"Add foundation team as reviewer" took an action on this PR • (03/22/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add consumer team as reviewer" took an action on this PR • (03/22/24)1 reviewer was added to this PR based on Keith Williams's automation. |
joeauyeung
previously requested changes
Mar 28, 2024
Contributor
joeauyeung
left a comment
joeauyeung
left a comment
There was a problem hiding this comment.
Great work so far @Udit-takkar. I know we're just trying to get a V1 out the door but I still have a few blocking comments.
Non-blocking
- What's up with all the Lucide icon changes? Do we need those?
| ); | ||
| const formMethods = useFormContext<FormValues>(); | ||
|
|
||
| const isOrg = !!session.data?.user?.org?.id; |
Contributor
There was a problem hiding this comment.
NIT: Could find a more reusable way to determine this in a follow up.
Comment on lines
+241
to
+246
| <Button | ||
| disabled={createCallMutation.isPending} | ||
| loading={createCallMutation.isPending} | ||
| onClick={handleSubmit}> | ||
| Make a Call | ||
| </Button> |
Contributor
There was a problem hiding this comment.
NIT: I think this button should be renamed. I see "Make a call" I expect a call to happen on the frontend but I see it's just creating the LLM. This could be confusing.
Contributor
There was a problem hiding this comment.
It is creating LLM and then making the call to "numberToCall"
Contributor
zomars upgraded that package. I just fixed the type errors related to that change |
PeerRich
commented
Mar 28, 2024
Member
Author
PeerRich
left a comment
PeerRich
left a comment
There was a problem hiding this comment.
awesome! approved. lets get this to prod today. added RETELL_AI_KEY to production environments
emrysal
previously approved these changes
Mar 28, 2024
Contributor
emrysal
left a comment
emrysal
left a comment
There was a problem hiding this comment.
Reviewed, happy to merge
Udit-takkar
approved these changes
Mar 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.