Skip to content

fix: failing webhookTriggers cron job#14104

Merged
emrysal merged 2 commits intomainfrom
fix/webhookTriggers-cron-api
Mar 18, 2024
Merged

fix: failing webhookTriggers cron job#14104
emrysal merged 2 commits intomainfrom
fix/webhookTriggers-cron-api

Conversation

@CarinaWolli
Copy link
Copy Markdown
Member

What does this PR do?

webhookTriggers cron job is failing right now with the following error:
NotFoundError [PrismaClientKnownRequestError]: No Webhook found

This can happen because right now we don’t delete WebhookScheduledTriggers when the webhook itself is deleted. Created another issue for that #14103

@graphite-app graphite-app Bot requested a review from a team March 15, 2024 15:06
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 15, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@keithwillcode keithwillcode added consumer core area: core, team members only labels Mar 15, 2024
@CarinaWolli CarinaWolli added webhooks area: webhooks, callback, webhook payload 🐛 bug Something isn't working labels Mar 15, 2024
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Mar 15, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (03/15/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@deploysentinel
Copy link
Copy Markdown

deploysentinel Bot commented Mar 15, 2024

Current Playwright Test Results Summary

✅ 303 Passing - ⚠️ 10 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 03/18/2024 03:46:07pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 3557421

Started: 03/18/2024 03:42:43pm UTC

⚠️ Flakes

📄   apps/web/playwright/login.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Login and logout tests -- legacy Login flow validations -- legacy Should warn when user does not exist
Retry 1Initial Attempt
0% (0) 0 / 183 runs
failed over last 7 days
4.92% (9) 9 / 183 runs
flaked over last 7 days

📄   apps/web/playwright/booking-seats.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Reschedule for booking with seats If rescheduled/cancelled booking with seats it should display the correct number of seats
Retry 1Initial Attempt
0% (0) 0 / 187 runs
failed over last 7 days
5.35% (10) 10 / 187 runs
flaked over last 7 days

📄   apps/web/playwright/booking-pages.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
pro user -- legacy Time slots should be reserved when selected
Retry 1Initial Attempt
0% (0) 0 / 187 runs
failed over last 7 days
8.02% (15) 15 / 187 runs
flaked over last 7 days
prefill -- legacy logged in
Retry 1Initial Attempt
0% (0) 0 / 187 runs
failed over last 7 days
2.14% (4) 4 / 187 runs
flaked over last 7 days

📄   apps/web/playwright/profile.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Update Profile Can resend verification link if the secondary email is unverified
Retry 1Initial Attempt
5.46% (10) 10 / 183 runs
failed over last 7 days
22.95% (42) 42 / 183 runs
flaked over last 7 days

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests -- legacy user Different Locations Tests Can remove location from multiple locations that are saved
Retry 1Initial Attempt
0% (0) 0 / 186 runs
failed over last 7 days
20.43% (38) 38 / 186 runs
flaked over last 7 days

📄   apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Stripe integration Can book a paid booking
Retry 1Initial Attempt
7.04% (14) 14 / 199 runs
failed over last 7 days
35.18% (70) 70 / 199 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/preview.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Preview Preview - embed-core should load
Retry 1Initial Attempt
0% (0) 0 / 190 runs
failed over last 7 days
33.68% (64) 64 / 190 runs
flaked over last 7 days

📄   apps/web/playwright/signup.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Signup Flow Test Signup with valid (non premium) username
Retry 2Retry 1Initial Attempt
2.54% (5) 5 / 197 runs
failed over last 7 days
10.66% (21) 21 / 197 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 1Initial Attempt
1.57% (3) 3 / 191 runs
failed over last 7 days
45.03% (86) 86 / 191 runs
flaked over last 7 days

View Detailed Build Results


Copy link
Copy Markdown
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@emrysal emrysal enabled auto-merge (squash) March 15, 2024 15:57
@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2024 3:32pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Mar 18, 2024 3:32pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Mar 18, 2024 3:32pm
qa ⬜️ Ignored (Inspect) Visit Preview Mar 18, 2024 3:32pm

@github-actions
Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@emrysal emrysal merged commit 4b76443 into main Mar 18, 2024
@emrysal emrysal deleted the fix/webhookTriggers-cron-api branch March 18, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working consumer core area: core, team members only webhooks area: webhooks, callback, webhook payload

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants