Skip to content

fix: dynamic event length change on reschedule#14110

Merged
CarinaWolli merged 6 commits intocalcom:mainfrom
Shobana7:fix/event-length-change-on-reschedule
Mar 18, 2024
Merged

fix: dynamic event length change on reschedule#14110
CarinaWolli merged 6 commits intocalcom:mainfrom
Shobana7:fix/event-length-change-on-reschedule

Conversation

@Shobana7
Copy link
Copy Markdown
Contributor

What does this PR do?

This PR fixes the dynamic-event length change upon rescheduling a booking. Following the reschedule link from email or simple URL reload fetched the default eventType length.

Fixes #14083

Video

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Steps to Reproduce

  • Create a dynamic event type
  • Schedule a booking with duration different from default event duration
  • Click on reschedule from the booking confirmation page
  • Refresh the URL by providing only the rescheduleUid and removing other query params

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@graphite-app graphite-app Bot added the community Created by Linear-GitHub Sync label Mar 15, 2024
@graphite-app graphite-app Bot requested review from a team March 15, 2024 23:44
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 15, 2024

@Shobana7 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 15, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@github-actions github-actions Bot added bookings area: bookings, availability, timezones, double booking ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work ✅ good first issue Good for newcomers 🐛 bug Something isn't working labels Mar 15, 2024
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Mar 15, 2024

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (03/15/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (03/15/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (03/15/24)

1 label was added to this PR based on Keith Williams's automation.

@Shobana7 Shobana7 changed the title Fixed dynamic event length change on reschedule Fix: dynamic event length change on reschedule Mar 15, 2024
@Shobana7 Shobana7 changed the title Fix: dynamic event length change on reschedule fix: dynamic event length change on reschedule Mar 15, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 16, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@Ryukemeister
Copy link
Copy Markdown
Contributor

Ryukemeister commented Mar 16, 2024

@Shobana7 looks like you've made changes to the yarn.lock file. Ideally we only change that file while adding or removing any new dependencies, can you revert those changes with reference to this https://github.com/calcom/cal.com/blob/main/CONTRIBUTING.md#guidelines-for-committing-yarn-lockfile

@Shobana7
Copy link
Copy Markdown
Contributor Author

Reverted changes to yarn.lock

Copy link
Copy Markdown
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CarinaWolli CarinaWolli merged commit ece74cb into calcom:main Mar 18, 2024
@Shobana7 Shobana7 deleted the fix/event-length-change-on-reschedule branch March 18, 2024 19:49
@Shobana7 Shobana7 restored the fix/event-length-change-on-reschedule branch March 18, 2024 19:49
@Shobana7 Shobana7 deleted the fix/event-length-change-on-reschedule branch March 18, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working community Created by Linear-GitHub Sync ✅ good first issue Good for newcomers ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dynamic Event length changes to 30min upon reschedule even if original is not 30min

5 participants